-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
git-cola: Depend on qtwayland on Linux #256869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Failure is a "no space left on device". This got past lints that I thought would fail, though. |
|
Something that I thought about this morning: while adding this dependency gets this package (and another new one I'm working on) to work for me since Bluefin uses Wayland, there may be others that are using something else. Maybe this should be in the caveats instead of a hard dependency, unless Homebrew on Linux can detect display manager and depend on the right thing based on that. I can't find anything in the documentation to that effect, though. |
|
@colindean Please squash into 1 commit and this should be good to go. |
This enables `git-cola`to start for me on Bluefin gts-41.20251019. But don't link qtwayland, per Rui's comment. Fixes Homebrew#231275 Co-authored-by: Rui Chen <[email protected]>
p-linnane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
🤖 An automated task has requested bottles to be published to this PR. Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
This enables
git-colato start for me on Bluefin gts-41.20251019.Fixes #231275
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?WIP: I made this edit in GitHub and expect CI to yell at me.It got past the lints I thought would fail, so I'll take it out of draft.