Skip to content

Conversation

@colindean
Copy link
Contributor

@colindean colindean commented Dec 3, 2025

This enables git-colato start for me on Bluefin gts-41.20251019.

Fixes #231275

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

WIP: I made this edit in GitHub and expect CI to yell at me. It got past the lints I thought would fail, so I'll take it out of draft.

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Dec 3, 2025
@colindean
Copy link
Contributor Author

Failure is a "no space left on device". This got past lints that I thought would fail, though.

@colindean colindean marked this pull request as ready for review December 3, 2025 06:05
@daeho-ro daeho-ro added the CI-linux-self-hosted Build on Linux self-hosted runner label Dec 3, 2025
@colindean
Copy link
Contributor Author

colindean commented Dec 3, 2025

Something that I thought about this morning: while adding this dependency gets this package (and another new one I'm working on) to work for me since Bluefin uses Wayland, there may be others that are using something else. Maybe this should be in the caveats instead of a hard dependency, unless Homebrew on Linux can detect display manager and depend on the right thing based on that. I can't find anything in the documentation to that effect, though.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 4, 2025
@p-linnane
Copy link
Member

@colindean Please squash into 1 commit and this should be good to go.

This enables `git-cola`to start for me on Bluefin gts-41.20251019.

But don't link qtwayland, per Rui's comment.

Fixes Homebrew#231275

Co-authored-by: Rui Chen <[email protected]>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 6, 2025
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 6, 2025
@BrewTestBot BrewTestBot enabled auto-merge December 6, 2025 11:37
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 6, 2025
Merged via the queue into Homebrew:main with commit fe0c9eb Dec 6, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-linux-self-hosted Build on Linux self-hosted runner CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git-cola wont start due to missing qt platform plugins

5 participants