Skip to content

Remove Cartfile before building via Carthage #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredpi merged 3 commits into from
Jun 18, 2019
Merged

Remove Cartfile before building via Carthage #57

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d589a38
Remove Cartfile before building via Carthage
fredpi Jun 17, 2019
7ec620d
Improve language in comment
fredpi Jun 18, 2019
eece3e1
Add changelog entry
fredpi Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/AccioKit/Services/CarthageBuilderService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,12 @@ final class CarthageBuilderService {
try bash("ln -f -s '\(requiredFrameworkProduct.symbolsFilePath)' '\(productsTargetDirectoryUrl.path)'")
}

// remove Cartfile before carthage build as subdependencies have already been built via Accio
try bash("rm -rf '\(framework.projectDirectory)/Cartfile'")
try bash("rm -rf '\(framework.projectDirectory)/Cartfile.resolved'")

try XcodeProjectSchemeHandlerService.shared.removeUnnecessarySharedSchemes(from: framework, platform: platform)

try bash("/usr/local/bin/carthage build --project-directory '\(framework.projectDirectory)' --platform \(platform.rawValue) --no-skip-current --no-use-binaries")

let frameworkProduct = FrameworkProduct(libraryName: framework.libraryName, platformName: platform.rawValue)
Expand Down