feat: add support for quoted alias#33
Merged
albin3 merged 1 commit intoJavaScriptor:masterfrom Mar 30, 2020
TrackTik:master
Merged
feat: add support for quoted alias#33albin3 merged 1 commit intoJavaScriptor:masterfrom TrackTik:master
albin3 merged 1 commit intoJavaScriptor:masterfrom
TrackTik:master
Conversation
Member
|
@eortiz-tracktik It's an identifier in code. https://github.com/JavaScriptor/js-sql-parser/blob/master/src/sqlParser.jison#L14 |
Contributor
Author
|
@albin3 thanks for the quick response. I saw that there was already the concept of QUOTED_IDENTIFIER but was also limited to certain characters. |
Member
|
@eortiz-tracktik you are right! thanks for this pr. 😺 |
Member
|
|
Contributor
Author
|
Thanks a lot to you @albin3 for this awesome project! 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using this parser and we would like to be able to use quoted alias like on the tests.
Basically, anything quoted should be safe as a quoted identifier?
Thanks.