Add parse_key and parse_public_key methods#282
Open
devmotion wants to merge 3 commits intoJuliaLang:masterfrom
Open
Add parse_key and parse_public_key methods#282devmotion wants to merge 3 commits intoJuliaLang:masterfrom
parse_key and parse_public_key methods#282devmotion wants to merge 3 commits intoJuliaLang:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
==========================================
+ Coverage 75.98% 76.25% +0.26%
==========================================
Files 12 12
Lines 712 720 +8
==========================================
+ Hits 541 549 +8
Misses 171 171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Bump 🙂 |
Member
|
Who would be the right person to review this? @quinnj maybe? |
Member
|
Bump @quinnj - Could you review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
MbedTLS.parse_keyandMbedTLS.parse_public_keymethods which are arguably convenient additions and complementMbedTLS.parse_key!andMbedTLS.parse_public_key!in the same way asMbedTLS.parse_keyfile/MbedTLS.parse_keyfile!andMbedTLS.parse_public_keyfile/MbedTLS.parse_public_keyfile!.