Commit 7f1add2
authored
SharedArrays: Skip a
In theory, if we throw on line 116 (e.g. if `getpid()` or `randstring()`
throws), then we'll enter the `finally` block before we ever define
`shmmem_create_pid`. I think this case is unlikely, but if we do hit it,
we can't perform the `remotecall_fetch` call in the `finally` block,
because `shmmem_create_pid` won't be defined.
So this PR checks if `shmmem_create_pid` is defined before doing the
`remotecall_fetch` call.
Alternatively, we could lift lines 116 and 117 out of the `try` block,
at which point it will no longer be possible (as far as I can tell) for
us to throw before defining `shmmem_create_pid`.
---
Detected by JET.finally step if we throw before the shmmem_create_pid local is defined (#61141)1 parent 03f7bcd commit 7f1add2
1 file changed
Lines changed: 1 addition & 1 deletion
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
| 156 | + | |
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
| |||
0 commit comments