move Mmap and SharedArrays to stdlib#23931
Merged
JeffBezanson merged 2 commits intomasterfrom Sep 30, 2017
Merged
Conversation
b880891 to
b6fde00
Compare
b6fde00 to
6004f43
Compare
6004f43 to
af97d70
Compare
Member
|
Thrilled to see this happening. This experience probably needs to be improved, however :) julia> Mmap
WARNING: Base.Mmap is deprecated, run `using Mmap` instead.
likely near no file:0
julia> using Mmap
WARNING: using Mmap.Mmap in module Main conflicts with an existing identifier.
ERROR: importing Mmap into Main conflicts with an existing identifier |
Member
|
BSD CI got error after this PR merged |
Member
|
🤔 why did it try to load things from |
Member
|
https://julia.iblis.cnmc.tw/#/builders/1/builds/2843/steps/6/logs/stdio In this case, home path is correct, but still has trouble with relative path. |
Member
|
Can reproduce on Linux as well: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One or both of these might go on to become an external package, but this at least does part of the work.