Move LibGit2 to stdlib

[KristofferC]

Made on top of #25705.

I have a few comments inline.

There was some problems with the documentation generation locally, so we will see what happens here.

[KristofferC]

Need to figure out what to do with this one url(::Method)...

[KristofferC]

Not sure exactly what this is testing, perhaps just a deep nesting.

[vchuravy]

These deprecations were made during the 0.7 cycle so they need to use @deprecate_moved or @deprecate_stdlib after #25692

[KristofferC]

Hmm, the behavior right now is:

julia> Base.LibGit2.prompt("Hello?")
WARNING: Base.LibGit2 is deprecated, run `import LibGit2` instead.
 in module Base
┌ Warning: `LibGit2.prompt(msg::AbstractString; default::AbstractString="", password::Bool=false)` is deprecated, use `result = Base.prompt(msg, default=default, password=password); result === nothing ? "" : result` instead.
│   caller = top-level scope
└ @ Core :0
Hello?:yes
"yes"

Isn't that ok?

[vchuravy]

Oh I didn't think that would happen. Neat. You get a deprecation warning for Base.LibGit2 and then a separate one for prompt. So as long as non of these were exported everything should be ok.

[omus]

Is it possible to move out the libgit2 C library with this? It would be nice to be able to update the revision of the shared library during 1.0.

[waldyrious]

Suggestion: "it becomes" --> "which becomes", to avoid a comma splice.

[StefanKarpinski]

Is it possible to move out the libgit2 C library with this? It would be nice to be able to update the revision of the shared library during 1.0.

1.0 API stability definitely does not include never changing versions of libraries that we depend on.

[KristofferC]

So this causes the documentation warnings:

 !! Invalid local link: unresolved path
    '../../devdocs/libgit2/#Base.LibGit2.GitRevWalker' in devdocs/libgit2.md
 !! Invalid local link: unresolved path
    '../../devdocs/libgit2/#Base.LibGit2.GitHash' in devdocs/libgit2.md
 !! Invalid local link: unresolved path
    '../../devdocs/libgit2/#Base.LibGit2.push_head!' in devdocs/libgit2.md
 !! Invalid local link: unresolved path
    '../../devdocs/libgit2/#Base.LibGit2.GitRevWalker' in devdocs/libgit2.md
 !! Invalid local link: unresolved path
    '../../devdocs/libgit2/#Base.LibGit2.GitHash' in devdocs/libgit2.md
 !! Invalid local link: unresolved path
    '../../devdocs/libgit2/#Base.LibGit2.push_head!' in devdocs/libgit2.md

to turn into:

 !! No doc found for reference '[`GitRevWalker`](@ref)'. [src/base/collections.md]
 !! No doc found for reference '[`GitHash`](@ref)'. [src/base/collections.md]
 !! No doc found for reference '[`push_head!`](@ref)'. [src/base/collections.md]
 !! No doc found for reference '[`GitRevWalker`](@ref)'. [src/base/collections.md]
 !! No doc found for reference '[`GitHash`](@ref)'. [src/base/collections.md]
 !! No doc found for reference '[`push_head!`](@ref)'. [src/base/collections.md]

which apparently fails the documentation build... I have no idea how to fix it but I temporarily turned off strict documentation build to see if the other tests pass.

[KristofferC]

CI straight flush. 🎉

So what is left to do here is:

• Figure out what to do with url(::Method) when the Method is defined in a package:
  

  julia/base/methodshow.jl

  Lines 215 to 232 in 0f95988

  	try
  	d = dirname(file)
  	return LibGit2.with(LibGit2.GitRepoExt(d)) do repo
  	LibGit2.with(LibGit2.GitConfig(repo)) do cfg
  	u = LibGit2.get(cfg, "remote.origin.url", "")
  	u = match(LibGit2.GITHUB_REGEX,u).captures[1]
  	commit = string(LibGit2.head_oid(repo))
  	root = LibGit2.path(repo)
  	if startswith(file, root) || startswith(realpath(file), root)
  	"https://github.com/$u/tree/$commit/"*file[length(root)+1:end]*"#L$line"
  	else
  	fileurl(file)
  	end
  	end
  	end
  	catch
  	return fileurl(file)
  	end

  I suggest that we simply delete it since it assumed that packages are git repos which will not be the case.

• Figure out how to get documentation to pass with strict = true (see Move LibGit2 to stdlib #25706 (comment)). I have no idea about this, to be honest. These errors come when trying to reference LibGit2 docstrings from Base.map so one way would be to not have LibGit2 extend Base.map and instead define its own (similar to how it was done with push!).

Opinions?

[JeffBezanson]

I certainly wouldn't want to lose method URLs in jupyter; it's a cool feature.

[KristofferC]

Is bbf2224 acceptable as a way out of this deadlock?

[JeffBezanson]

Sure, let's do that for now.