Improve error messages by showing more context#1433
Open
fingolfin wants to merge 1 commit intoJuliaLang:mainfrom
Open
Improve error messages by showing more context#1433fingolfin wants to merge 1 commit intoJuliaLang:mainfrom
fingolfin wants to merge 1 commit intoJuliaLang:mainfrom
Conversation
E.g. when failing to modify a file, include the path to the file Co-authored-by: Codex <codex@openai.com>
Member
Author
|
Tests pass. I manually went over the PR to verify the AI did not produce arbitrary garbage, it all seems sensible. Though of course I can not guarantee it is all perfect (I couldn't if I had written it myself either...). Though if this causes regressions, I offer to take care of them (in the worst case by reverting select messages to their prior state). I also verified that it improves the error message in cases I care about. So I hope this can be merged? |
Member
Author
|
(In other words: would be great if someone could approve this, then I can merge it... ;-) ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. when failing to modify a file, include the path to the file.
Resolves #1430.
Co-authored-by: Codex codex@openai.com