From 83c7aa0b4bd2f1e77fde4699b0145f604d190431 Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Wed, 3 Aug 2022 12:48:25 +0200 Subject: [PATCH 1/6] Adjustment to `AdjointQ` introduction in LinearAlgebra --- src/svd.jl | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/svd.jl b/src/svd.jl index 30718c3..59fde59 100644 --- a/src/svd.jl +++ b/src/svd.jl @@ -1,6 +1,11 @@ using LinearAlgebra import LinearAlgebra: mul!, rmul! +@static if VERSION > v"1.8" + AdjointQtype = LinearAlgebra.AdjointQ +else + AdjointQtype = Adjoint +end lmul!(G::LinearAlgebra.Givens, ::Nothing) = nothing rmul!(::Nothing, G::LinearAlgebra.Givens) = nothing @@ -355,7 +360,7 @@ function lmul!(Q::LinearAlgebra.HessenbergQ, B::AbstractVecOrMat) return B end -function lmul!(adjQ::Adjoint{<:Any,<:LinearAlgebra.HessenbergQ}, B::AbstractVecOrMat) +function lmul!(adjQ::AdjointQtype{<:Any,<:LinearAlgebra.HessenbergQ}, B::AbstractVecOrMat) Q = parent(adjQ) m, n = size(B, 1), size(B, 2) @@ -406,8 +411,7 @@ function rmul!(A::AbstractMatrix, Q::LinearAlgebra.HessenbergQ) return A end -function rmul!(A::AbstractMatrix, adjQ::Adjoint{<:Any,<:LinearAlgebra.HessenbergQ}) - +function rmul!(A::AbstractMatrix, adjQ::AdjointQtype{<:Any,<:LinearAlgebra.HessenbergQ}) m, n = size(A) Q = parent(adjQ) From d59e7cce915dcbe7049c7831e62a8cebf2e6dc55 Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Wed, 3 Aug 2022 12:59:02 +0200 Subject: [PATCH 2/6] bump patch version, specify version --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 95b422b..91f4dac 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "GenericLinearAlgebra" uuid = "14197337-ba66-59df-a3e3-ca00e7dcff7a" -version = "0.3.3" +version = "0.3.5" [deps] LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" From bf6c753de5602fd6ca479e0e4aa331d543b2577d Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Mon, 22 Aug 2022 18:40:18 +0200 Subject: [PATCH 3/6] adjust version number --- src/svd.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/svd.jl b/src/svd.jl index 59fde59..2656623 100644 --- a/src/svd.jl +++ b/src/svd.jl @@ -1,7 +1,7 @@ using LinearAlgebra import LinearAlgebra: mul!, rmul! -@static if VERSION > v"1.8" +@static if VERSION >= v"1.9-" AdjointQtype = LinearAlgebra.AdjointQ else AdjointQtype = Adjoint From 68dd093b7900b8218df5363f87103f18714d463a Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Sat, 24 Sep 2022 13:16:47 +0200 Subject: [PATCH 4/6] Update svd.jl --- src/svd.jl | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/svd.jl b/src/svd.jl index 2656623..e96937c 100644 --- a/src/svd.jl +++ b/src/svd.jl @@ -1,11 +1,8 @@ using LinearAlgebra import LinearAlgebra: mul!, rmul! -@static if VERSION >= v"1.9-" - AdjointQtype = LinearAlgebra.AdjointQ -else - AdjointQtype = Adjoint -end + +AdjointQtype = isdefined(LinearAlgebra, :AdjointQ) ? : LinearAlgebra.AdjointQ : Adjoint lmul!(G::LinearAlgebra.Givens, ::Nothing) = nothing rmul!(::Nothing, G::LinearAlgebra.Givens) = nothing From 34e1f79a888a0ad0d8b6cc0a234afc026579160c Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Sat, 24 Sep 2022 13:17:22 +0200 Subject: [PATCH 5/6] Fix typo --- src/svd.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/svd.jl b/src/svd.jl index e96937c..bb4eb38 100644 --- a/src/svd.jl +++ b/src/svd.jl @@ -2,7 +2,7 @@ using LinearAlgebra import LinearAlgebra: mul!, rmul! -AdjointQtype = isdefined(LinearAlgebra, :AdjointQ) ? : LinearAlgebra.AdjointQ : Adjoint +AdjointQtype = isdefined(LinearAlgebra, :AdjointQ) ? LinearAlgebra.AdjointQ : Adjoint lmul!(G::LinearAlgebra.Givens, ::Nothing) = nothing rmul!(::Nothing, G::LinearAlgebra.Givens) = nothing From 7c37d19b4eeac841cc52e069ad5afd6ff135855c Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Tue, 29 Nov 2022 10:52:31 +0100 Subject: [PATCH 6/6] fix Quaternions.jl version for testing --- Project.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/Project.toml b/Project.toml index 91f4dac..79312ad 100644 --- a/Project.toml +++ b/Project.toml @@ -9,6 +9,7 @@ Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" libblastrampoline_jll = "8e850b90-86db-534c-a0d3-1478176c7d93" [compat] +Quaternions = "=0.6.0" julia = "1.6" [extras]