fix accuracy of logcosh(::Union{Float16, Float32, Float64})#101
Merged
tpapp merged 11 commits intoJuliaStats:masterfrom Aug 17, 2025
nsajko:logcosh_accuracy
Merged
fix accuracy of logcosh(::Union{Float16, Float32, Float64})#101tpapp merged 11 commits intoJuliaStats:masterfrom nsajko:logcosh_accuracy
logcosh(::Union{Float16, Float32, Float64})#101tpapp merged 11 commits intoJuliaStats:masterfrom
nsajko:logcosh_accuracy
Conversation
Contributor
Author
Plots of the error in ULPs after this change
The plotting happens after downsampling (which just takes the maximum value), which itself happens after smoothing (which also just takes the maximum, i.e., a sliding window maximum). Thus the downsampling and smoothing basically just remove the downward spikes of the noise, preserving the maximum error at the region around each point. |
oscardssmith has been reviewing the `ULPError` code on JuliaLang/julia#59087 So sync the code with the changes there.
tpapp
approved these changes
Aug 8, 2025
devmotion
reviewed
Aug 8, 2025
Contributor
Author
|
bump |
devmotion
reviewed
Aug 14, 2025
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
The PR looks good, I just wonder if we could cover Float16 as well?
nsajko
changed the title
logcosh(::Union{Float32, Float64})logcosh(::Union{Float16, Float32, Float64})
Collaborator
|
@nsajko: thanks for adding |
devmotion
approved these changes
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100