feat(tendermint): support unsigned txs for ledger's keplr extension #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
external-sign-keplr-ledger
branch
from
89ee914 to
4263525
Compare
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
external-sign-keplr-ledger
branch
from
4263525 to
4af3927
Compare
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
shamardy
reviewed
Jul 1, 2024
Collaborator
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
Amazing work! Only one comment from my side.
mariocynicys
previously approved these changes
Jul 1, 2024
| protocol_conf: Self::PlatformProtocolInfo, | ||
| ) -> Result<Self, MmError<Self::ActivationError>> { | ||
| let conf = TendermintConf::try_from_json(&ticker, coin_conf)?; | ||
| let is_keplr_from_ledger = activation_request.is_keplr_from_ledger && activation_request.with_pubkey.is_some(); |
Collaborator
There was a problem hiding this comment.
Q: Can this be a keplr from ledger but not with pubkey?
Collaborator
Author
There was a problem hiding this comment.
No, it can't. If you are using hardware wallet, with-pubkey is the only way you can use your wallet with mm2.
Collaborator
There was a problem hiding this comment.
Aha, then does it make sense to && activation_request.with_pubkey.is_some(). If we suspect the activation request might be malformed, maybe we could error here instead.
Signed-off-by: onur-ozkan <[email protected]>
shamardy
approved these changes
Jul 2, 2024
dimxy
pushed a commit
that referenced
this pull request
Jul 3, 2024
* dev: fix(restrictions): remove wallet-only restriction from max_maker_vol (#2153) feat(tendermint): support unsigned txs for ledger's keplr extension (#2148) chore(toolchain): upgrade to 1.72 nightly (#2149) feat(solana-swap): solana swap protocol v1 POC (#2091) fix(docs): update cargo test command (#2144)
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pubkey-only mode fails with Ledger's Keplr extension. This is because Ledger doesn't support
SIGN_MODE_DIRECTtransaction signing (more context).Ledger supports two signing modes at the moment:
The first one is a legacy signing type and doesn't support HTLC transactions, meaning we can't support swaps with it.
Unlike the first one, the second one is actively maintained but Keplr doesn't support it yet.
So we end up with having one option only; use
SIGN_MODE_LEGACY_AMINO_JSONand only support withdrawals for Ledger's Keplr extension.