feat(tendermint): improve the max handling for tendermint withdraw
#2155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onur-ozkan
changed the title
onur-ozkan
changed the title
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
increase-fee-multiplier-for-pubkey-mode
branch
from
eb4237a to
3129512
Compare
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
changed the title
max handling for tendermint withdraw
… into increase-fee-multiplier-for-pubkey-mode
onur-ozkan
force-pushed
the
increase-fee-multiplier-for-pubkey-mode
branch
from
a397b1f to
923bf9f
Compare
Signed-off-by: onur-ozkan <[email protected]>
dimxy
pushed a commit
that referenced
this pull request
Jul 21, 2024
* dev: feat(nft-swap): add standalone maker contract and proxy support (#2100) feat(ETH): add `gas_limit` coins param to override default values (#2137) feat(tendermint): implement better sequence resolving logic (#2164) ci(artifact): add target for macos on apple silicon (#2163) fix(helpers): extend http to ws address conversion (#2166) fix(makerbot): add "testcoin" to provider options (#2161) fix(hd_wallet): make extended pubkey of hd wallet generic (#2159) fix(docker-tests): implement containers runtime directories (#2162) feat(tendermint): improve the `max` handling for tendermint withdraw (#2155) revert #2158 (comment) (#2160) ci(artifacts): upload build artifacts with in-tree script (#2158) test(tendermint): migrate to local/offline containerized testnets (#2128) use easingthemes/[email protected] for all builds except windows (#2157) chore(bin): rename mm2 binaries to kdf (#2126)
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Aug 12, 2024
* dev: (22 commits) chore(release): bump mm2 version to 2.2.0-beta (GLEECBTC#2188) ci(docker-tests): ignore tendermint IBC tests for now (GLEECBTC#2185) feat(nft-swap): complete refund methods (GLEECBTC#2129) chore(release): add changelog entries for v2.1.0-beta (GLEECBTC#2165) fix(zcoin): don't force low r signing to generate htlc pubkey for zcoin (GLEECBTC#2184) chore(rust-analyzer): add rust-analyzer into the workspace toolchain (GLEECBTC#2179) chore: migrate .cargo/config to .cargo/config.toml to avoid deprecation warning (GLEECBTC#2177) fix(swaps): ensure taker payment spend confirmations (GLEECBTC#2176) feat(nft-swap): add standalone maker contract and proxy support (GLEECBTC#2100) feat(ETH): add `gas_limit` coins param to override default values (GLEECBTC#2137) feat(tendermint): implement better sequence resolving logic (GLEECBTC#2164) ci(artifact): add target for macos on apple silicon (GLEECBTC#2163) fix(helpers): extend http to ws address conversion (GLEECBTC#2166) fix(makerbot): add "testcoin" to provider options (GLEECBTC#2161) fix(hd_wallet): make extended pubkey of hd wallet generic (GLEECBTC#2159) fix(docker-tests): implement containers runtime directories (GLEECBTC#2162) feat(tendermint): improve the `max` handling for tendermint withdraw (GLEECBTC#2155) revert GLEECBTC#2158 (comment) (GLEECBTC#2160) ci(artifacts): upload build artifacts with in-tree script (GLEECBTC#2158) test(tendermint): migrate to local/offline containerized testnets (GLEECBTC#2128) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes tendermint to use more precise
maxamount for withdraw operations by removing the estimated fee (by simulating the transaction) from it.