feat(utxo): add new fixed txfee option for DINGO-like coins #2454

dimxy · 2025-05-13T14:24:57Z

Before this PR, for the utxo fixed fee calculation we rounded up txsize up to 1000 bytes. It was once required for the DOGE coin (but not anymore), but we did this for all utxo coins (what in fact unnecessarily increased txfee).
This rounding up is now required for few coins, like DINGO or RUNES.

With this PR, this txsize rounding up is not done by default.
Added a new fixed tx fee option "dingo_fee"=true, with rounding up, that could be set for a coin in the coins file.

Updated tests involving swap max volume and txfee (due to changed txfee calculation).

Fixes #2446 issue.

@cipig

This PR also has an internal design improvement:
For calculating max swap volume (trade_preimage max_taker_vol rpcs) we should take into account possible refund fee. In this PR the include_refund_fee param is eliminated and instead a new variant is added into the existing FeeApproxStage enum.

fix use gas_fee in build(); fix min_relay_tx_fee calc; refactor break build() into functions rename fn get_tx_fee to get_fee_per_kb; fix utxos tests for recalculated tx fee

* dev: feat(tendermint): validators RPC (#2310) chore(CI): validate Cargo lock file (#2309) test(P2P): add test for peer time sync validation (#2304)

fix refactored UtxoTxBuilder::build(): return only txfee (w/o gas fee) with tx as it used to be

refactor (borngraced): add_change simplified, remove tx_fee mut, use checked_sub

…true

… update txfee

* dev: (24 commits) fix(eth-tpu): remove state from funding validation (#2334) improvement(rpc-server): rpc server dynamic port allocation (#2342) fix(tests): fix or ignore unstable tests (#2365) fix(fs): make `filter_files_by_extension` return only files (#2364) fix(derive_key_from_path): check length of current_key_material (#2356) chore(release): bump mm2 version to 2.4.0-beta (#2346) fix(tests): add additional testnet sepolia nodes to test code (#2358) fix(swaps): maintain legacy compatibility for negotiation messages (#2353) refactor(SwapOps): impl defaults for protocol specific swapops fns (#2354) feat(tpu-v2): provide swap protocol versioning (#2324) feat(wallet): add change mnemonic password rpc (#2317) fix(tpu-v2): fix tpu-v2 wait for payment spend and extract secret (#2261) feat(tendermint): unstaking/undelegation (#2330) fix(utxo-withdraw): get hw ctx only when `PrivKeyPolicy` is trezor (#2333) feat(event-streaming): API-driven subscription management (#2172) fix(hash-types): remove panic, enforce fixed-size arrays (#2279) fix(ARRR): store unconfirmed change output (#2276) feat(tendermint): staking/delegation (#2322) chore(deps): `timed-map` migration (#2247) fix(mem-leak): `running_swap` never shrinks (#2301) ...

…sable txfee helpers

…ange

cipig · 2025-06-24T17:21:24Z

can i please have a new build of this? the old one was removed

* dev: chore(core): replace hash_raw_entry with stable entry() API (#2473) chore(core): adapt `MmError` and usages for compatibility with new rustc versions (#2443) feat(wallet): add `delete_wallet` RPC (#2497) chore(release): add changelog entries for v2.5.0-beta (#2494) chore(release): bump kdf version to 2.5.0-beta (#2492) feat(tests): zcoin unit test to validate dex fee (#2460) # Conflicts: # mm2src/coins/qrc20.rs # mm2src/mm2_main/src/lp_swap/maker_swap.rs

dimxy · 2025-06-29T08:09:19Z

Merged with dev and fixed several preimage volume tests broken due to new DEFAULT_SWAP_TX_SPEND_SIZE value in the dev (ad1cdf4).

(Note: I added env vars _KDF_NO_UTXO_DOCKER, _KDF_NO_QTUM_DOCKER etc to disable start of unneeded docker containers for easier docker tests debugging)

* dev: fix(eth): Correctly implement ETH max withdrawal logic (#2531) feat(use-clap-for-cli): use clap to parse CLI-Args #2215 (#2510) feat(orderbook): expirable maker orders (#2516) improvement(eth): drop parity support (#2527) chore(release): finalize changelog for v2.5.0-beta (#2524) chore(toolchain): upgrade toolchain to nightly 1.86.0 (#2444) feat(swap): rpc to find best swap with liquidity routing for ask (#2362) fix(kdf_walletconnect): apply explicit MmError mapping (#2514) fix(walletconnect): centralize connection and retry logic (#2508) fix(hw-wallet): avoid calling `get_enabled_address` in trezor-based coin init (#2504)

cipig · 2025-07-22T06:29:59Z

can we please merge this? using it on all makers since a long time and works perfectly fine

shamardy · 2025-07-22T06:39:20Z

can we please merge this? using it on all makers since a long time and works perfectly fine

Have to do my own line by line review, utxo fee changes PRs are usually complex and require rigorous review.

shamardy

LGTM!

shamardy · 2025-07-30T15:17:03Z

@dimxy test_electrum_tx_history fails here and not in dev

dimxy · 2025-07-31T06:13:31Z

Thank you
(I wanted yet to check why this test was failing: test_order_cancellation_received_before_creation. I ll fix it in another PR then, if possible to fix)

shamardy · 2025-07-31T08:48:24Z

I wanted yet to check why this test was failing: test_order_cancellation_received_before_creation. I ll fix it in another PR then, if possible to fix

It's failing in dev so it's not this PR. I did check it yesterday and went back all the commits until the commit that introduced it and it still fails locally. I am thinking of ignoring it or changing how the test covers this case.

dimxy · 2025-07-31T09:41:05Z

I wanted yet to check why this test was failing: test_order_cancellation_received_before_creation. I ll fix it in another PR then, if possible to fix

It's failing in dev so it's not this PR. I did check it yesterday and went back all the commits until the commit that introduced it and it still fails locally. I am thinking of ignoring it or changing how the test covers this case.

Yeah I thought maybe just increasing the wait-for-log timeout would help but it didn't, seems a more complex problem.

* dev: (21 commits) feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (#2454) ci(pull-requests): review notification bot (#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538) bless clippy (#2560) refactor(toolchain): use latest available stable compiler (#2557) feat(wallet): implement unified offline private key export API (#2542) improve note for docker test start failure (#2550) fix(DOCS): add note for macos to fix docker containers startup failure (#2544) refactor(toolchain): general stabilization for stable rust (#2528) fix(ci): adds nodejs 20 to ci-container (#2536) fix(WASM and Debian): fix build failures (#2534) improvement(event-streaming): impl DeriveStreamerId trait for all streamers (#2489) fix(eth): Propagate structured EIP-1559 fee errors (#2532) fix(eth): Correctly implement ETH max withdrawal logic (#2531) feat(use-clap-for-cli): use clap to parse CLI-Args #2215 (#2510) feat(orderbook): expirable maker orders (#2516) improvement(eth): drop parity support (#2527) chore(release): finalize changelog for v2.5.0-beta (#2524) chore(toolchain): upgrade toolchain to nightly 1.86.0 (#2444) ... # Conflicts: # mm2src/coins/lp_coins.rs # mm2src/coins/rpc_command/get_new_address.rs # mm2src/trezor/src/eth/eth_command.rs

* dev: feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (#2454) ci(pull-requests): review notification bot (#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538) bless clippy (#2560) refactor(toolchain): use latest available stable compiler (#2557) feat(wallet): implement unified offline private key export API (#2542) improve note for docker test start failure (#2550) fix(DOCS): add note for macos to fix docker containers startup failure (#2544) refactor(toolchain): general stabilization for stable rust (#2528) fix(ci): adds nodejs 20 to ci-container (#2536) fix(WASM and Debian): fix build failures (#2534) improvement(event-streaming): impl DeriveStreamerId trait for all streamers (#2489) chore(release): v2.3.0-beta (#2284) # Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/eth_swap_v2/eth_maker_swap_v2.rs # mm2src/coins/eth/eth_swap_v2/eth_taker_swap_v2.rs # mm2src/coins/eth/eth_tests.rs # mm2src/coins/eth/eth_withdraw.rs # mm2src/coins/eth/v2_activation.rs # mm2src/coins/nft.rs # mm2src/coins/qrc20.rs # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/rpcs.rs # mm2src/mm2_main/src/rpc/lp_commands/tokens.rs # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs

* dev: (24 commits) fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580) fix(clippy): fix clippy warnings for #2565 (#2589) fix(Trezor): fix utxo and eth calls due to firmware changes (#2565) fix(utxo): calculate min_trading_vol based on fixed tx fees (#2564) feat(protocol): [0] solana support (#2586) fix(utxo): fix header deserialization; guard AuxPoW (#2583) chore(rust 1.89): make CI clippy/fmt pass (wasm32, all-targets) (#2581) fix(utxo): deserialize sapling root for PIVX block headers (#2572) improvement(dep-stack): security bumps (#2562) fix(utxo): correct block header deserialization for AuxPow and KAWPOW coins (#2563) feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (#2454) ci(pull-requests): review notification bot (#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538) bless clippy (#2560) refactor(toolchain): use latest available stable compiler (#2557) feat(wallet): implement unified offline private key export API (#2542) improve note for docker test start failure (#2550) fix(DOCS): add note for macos to fix docker containers startup failure (#2544) refactor(toolchain): general stabilization for stable rust (#2528) ... # Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/eth_swap_v2/eth_maker_swap_v2.rs # mm2src/coins/eth/eth_swap_v2/eth_taker_swap_v2.rs # mm2src/coins/eth/eth_tests.rs # mm2src/coins/eth/eth_withdraw.rs # mm2src/coins/eth/v2_activation.rs # mm2src/coins/nft.rs # mm2src/coins/qrc20.rs # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/rpcs.rs # mm2src/mm2_main/src/rpc/lp_commands/tokens.rs # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs

* dev: improvement(`static mut`s): `static mut` removal (#2590) fix(orders): set subscription on kickstart and skip GC of own pubkeys (#2597) fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580) fix(clippy): fix clippy warnings for #2565 (#2589) fix(Trezor): fix utxo and eth calls due to firmware changes (#2565) fix(utxo): calculate min_trading_vol based on fixed tx fees (#2564) feat(protocol): [0] solana support (#2586) fix(utxo): fix header deserialization; guard AuxPoW (#2583) chore(rust 1.89): make CI clippy/fmt pass (wasm32, all-targets) (#2581) fix(utxo): deserialize sapling root for PIVX block headers (#2572) improvement(dep-stack): security bumps (#2562) fix(utxo): correct block header deserialization for AuxPow and KAWPOW coins (#2563) feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (#2454) ci(pull-requests): review notification bot (#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538) bless clippy (#2560) refactor(toolchain): use latest available stable compiler (#2557) feat(wallet): implement unified offline private key export API (#2542) chore(release): v2.3.0-beta (#2284) # Conflicts: # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs

* dev: (28 commits) fix build script failing to find .git/HEAD (GLEECBTC#2601) refactor(EVM): rename fn, fix timeouts, add activation req validation (GLEECBTC#2543) improvement(`static mut`s): `static mut` removal (GLEECBTC#2590) fix(orders): set subscription on kickstart and skip GC of own pubkeys (GLEECBTC#2597) fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (GLEECBTC#2580) fix(clippy): fix clippy warnings for GLEECBTC#2565 (GLEECBTC#2589) fix(Trezor): fix utxo and eth calls due to firmware changes (GLEECBTC#2565) fix(utxo): calculate min_trading_vol based on fixed tx fees (GLEECBTC#2564) feat(protocol): [0] solana support (GLEECBTC#2586) fix(utxo): fix header deserialization; guard AuxPoW (GLEECBTC#2583) chore(rust 1.89): make CI clippy/fmt pass (wasm32, all-targets) (GLEECBTC#2581) fix(utxo): deserialize sapling root for PIVX block headers (GLEECBTC#2572) improvement(dep-stack): security bumps (GLEECBTC#2562) fix(utxo): correct block header deserialization for AuxPow and KAWPOW coins (GLEECBTC#2563) feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (GLEECBTC#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (GLEECBTC#2454) ci(pull-requests): review notification bot (GLEECBTC#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (GLEECBTC#2538) bless clippy (GLEECBTC#2560) refactor(toolchain): use latest available stable compiler (GLEECBTC#2557) ... # Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/eth_rpc.rs # mm2src/coins/eth/eth_swap_v2/eth_maker_swap_v2.rs # mm2src/coins/eth/eth_swap_v2/eth_taker_swap_v2.rs # mm2src/coins/eth/eth_withdraw.rs # mm2src/coins/eth/v2_activation.rs # mm2src/coins/lightning.rs # mm2src/coins/lp_coins.rs # mm2src/coins/nft.rs # mm2src/coins/qrc20.rs # mm2src/coins/siacoin.rs # mm2src/coins/tendermint/tendermint_token.rs # mm2src/coins/test_coin.rs # mm2src/coins/utxo/bch.rs # mm2src/coins/utxo/qtum.rs # mm2src/coins/utxo/slp.rs # mm2src/coins/utxo/utxo_standard.rs # mm2src/coins/z_coin.rs # mm2src/coins_activation/src/bch_with_tokens_activation.rs # mm2src/coins_activation/src/erc20_token_activation.rs # mm2src/coins_activation/src/eth_with_token_activation.rs # mm2src/coins_activation/src/init_erc20_token_activation.rs # mm2src/coins_activation/src/init_token.rs # mm2src/coins_activation/src/platform_coin_with_tokens.rs # mm2src/coins_activation/src/slp_token_activation.rs # mm2src/coins_activation/src/tendermint_with_assets_activation.rs # mm2src/coins_activation/src/token.rs # mm2src/mm2_main/src/lp_swap.rs # mm2src/mm2_main/src/lp_swap/check_balance.rs # mm2src/mm2_main/src/lp_swap/maker_swap.rs # mm2src/mm2_main/src/lp_swap/max_maker_vol_rpc.rs # mm2src/mm2_main/src/lp_swap/swap_v2_rpcs.rs # mm2src/mm2_main/src/lp_swap/taker_swap.rs # mm2src/mm2_main/src/lp_swap/trade_preimage.rs # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs # mm2src/mm2_main/src/rpc/lp_commands/legacy.rs # mm2src/mm2_main/src/rpc/lp_commands/lr_swap.rs # mm2src/mm2_main/src/rpc/lp_commands/lr_swap/lr_impl.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/errors.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/rpcs.rs # mm2src/mm2_main/src/rpc/lp_commands/tokens.rs # mm2src/mm2_main/tests/docker_tests/docker_tests_common.rs # mm2src/mm2_main/tests/docker_tests/docker_tests_inner.rs # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs # mm2src/mm2_main/tests/integration_tests_common/mod.rs # mm2src/trading_api/src/one_inch_api/client.rs

This commit make txsize not round up by default. It then adds a new fixed tx fee option "dingo_fee"=true, with rounding up, that could be set for a coin in the coins file.

dimxy and others added 30 commits January 8, 2025 23:52

fix UtxoTxBuilder::build() tx fee calculation to include change output;

cea1b2f

fix use gas_fee in build(); fix min_relay_tx_fee calc; refactor break build() into functions rename fn get_tx_fee to get_fee_per_kb; fix utxos tests for recalculated tx fee

Merge branch 'dev' into fix-utxo-tx-fee-for-change

455403c

* dev: feat(tendermint): validators RPC (#2310) chore(CI): validate Cargo lock file (#2309) test(P2P): add test for peer time sync validation (#2304)

fix qrc20 gas fee calc in trade preimage

8d2fe79

revert qtum gas_fee calc in trade preimage,

bc69a42

fix refactored UtxoTxBuilder::build(): return only txfee (w/o gas fee) with tx as it used to be

fix: err if change < dust (was <=)

40cfbda

refactor (borngraced): add_change simplified, remove tx_fee mut, use checked_sub

refactor (onur-ozkan): use refs instead of clone in add_tx_inputs

50a38f8

refactor (mariocynicys): fix return_err_if macro to check if cond is …

615ff3e

…true

refactor: rename vars to use always 'fee rate' root word

3f709fc

fix (mariocynicys): recalc kmd interest when tx inputs reselected and…

459a379

… update txfee

fix after merge

ad0699e

refactor (mariocynicys) removed unnecessary checks

1b2c538

fix fee_amount in AdditionalTxData, get rid of unused_change, add reu…

110a236

…sable txfee helpers

add extra test to check tx builder calc with many inputs

b5994e6

remove unused_change in utxo tx builder (var not used any more)

ae8c3ee

fix utxo tx builder test: add randomizer, catch overpay

9126c49

Merge remote-tracking branch 'origin/dev' into fix-utxo-tx-fee-for-ch…

997dcee

…ange

fix: remove txsize round up (for old doge support)

de945e6

add DINGO txfee coin param

de206b5

revert 'txfee' coin param to number, add 'dingo_fee' bool param

8a0ba28

fix txfee config parse with empty dingo_fee

529815f

fix utxo tests for the updated 'no-doge' tx fee calculation

53ce954

fix tx fee for change calc for no dingo coins

201648e

fix partially tests broken due to fee fix

0bb1756

dont start non utxo containers

49fa8e9

TODO trade preimage error and more test fix

c2715d0

dont pull non utxo images

fb555b6

more tests

caefe5d

fix test

6707f8c

more tests fixed

c4550a5

shamardy added 2.6.0-beta and removed 2.5.0-beta labels Jun 16, 2025

dimxy added 4 commits June 27, 2025 19:37

fix expected in tests due to DEFAULT_SWAP_TX_SPEND_SIZE changed to 496

ad1cdf4

restore envs to disable docker containers

11f75a5

test: make docker containers all start before use

a9b872f

shamardy mentioned this pull request Jul 22, 2025

feat(eth): improve gas fee policy code #2533

Merged

Merge branch 'dev' into fix-utxo-tx-fee-no-doge

a1f09ed

shamardy previously approved these changes Jul 30, 2025

View reviewed changes

fix expected balance in test_electrum_tx_history

be6cf93

dimxy dismissed shamardy’s stale review via be6cf93 July 30, 2025 15:56

shamardy approved these changes Jul 30, 2025

View reviewed changes

shamardy merged commit a19e442 into dev Jul 30, 2025
17 of 24 checks passed

shamardy deleted the fix-utxo-tx-fee-no-doge branch July 30, 2025 23:48

shamardy mentioned this pull request Nov 25, 2025

chore(release): v2.6.0-beta #2696

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(utxo): add new fixed txfee option for DINGO-like coins #2454

feat(utxo): add new fixed txfee option for DINGO-like coins #2454

Uh oh!

dimxy commented May 13, 2025 •

edited

Loading

Uh oh!

cipig commented Jun 24, 2025

Uh oh!

dimxy commented Jun 29, 2025

Uh oh!

cipig commented Jul 22, 2025

Uh oh!

shamardy commented Jul 22, 2025

Uh oh!

shamardy left a comment

Uh oh!

shamardy commented Jul 30, 2025

Uh oh!

Uh oh!

dimxy commented Jul 31, 2025

Uh oh!

shamardy commented Jul 31, 2025

Uh oh!

dimxy commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(utxo): add new fixed txfee option for DINGO-like coins #2454

feat(utxo): add new fixed txfee option for DINGO-like coins #2454

Uh oh!

Conversation

dimxy commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cipig commented Jun 24, 2025

Uh oh!

dimxy commented Jun 29, 2025

Uh oh!

cipig commented Jul 22, 2025

Uh oh!

shamardy commented Jul 22, 2025

Uh oh!

shamardy left a comment

Choose a reason for hiding this comment

Uh oh!

shamardy commented Jul 30, 2025

Uh oh!

Uh oh!

dimxy commented Jul 31, 2025

Uh oh!

shamardy commented Jul 31, 2025

Uh oh!

dimxy commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dimxy commented May 13, 2025 •

edited

Loading