fix(metrics): remove memory_db size metric #2632
Merged
+3
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I see, we opened a PR for merging into |
Collaborator
Author
Once any commit is merged straight to main I propagate it back to staging and dev. |
onur-ozkan
previously approved these changes
Oct 6, 2025
Collaborator
onur-ozkan
left a comment
onur-ozkan
left a comment
There was a problem hiding this comment.
If I recall correctly this also removes a vulnerable dependency.
LGTM
DeckerSU
previously approved these changes
Oct 6, 2025
DeckerSU
left a comment
DeckerSU
left a comment
There was a problem hiding this comment.
As I mentioned here - GLEECBTC/gleec-wallet#3169, LGTM.
shamardy
dismissed stale reviews from DeckerSU and onur-ozkan
The base branch was changed.
shamardy
added a commit
that referenced
this pull request
Oct 7, 2025
…x-staging-to-dev chore(release): propagate #2632 hotfix (staging→dev)
dimxy
pushed a commit
that referenced
this pull request
Oct 8, 2025
* dev: fix(TPU): correct dexfee in check balance to prevent swap failures (#2600) fix(tests): fix/remove kmd rewards failing test (#2633) chore(ci): bump CI container image to debian bullseye-slim to match dev (#2641) chore(release): add changelog entries for v2.5.2-beta (#2639) chore(release): bump mm2 version to 2.5.2-beta (#2638) feat(ci): add macos universal2 build (#2628) fix(metrics): remove memory_db size metric (#2632) chore(rust 1.90): make CI clippy/fmt pass Revert "fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580)" Revert "fix(orderbook): validate roots before commit (#2605)"
dimxy
pushed a commit
that referenced
this pull request
Oct 9, 2025
* dev: fix(TPU): correct dexfee in check balance to prevent swap failures (#2600) fix(tests): fix/remove kmd rewards failing test (#2633) chore(ci): bump CI container image to debian bullseye-slim to match dev (#2641) chore(release): add changelog entries for v2.5.2-beta (#2639) chore(release): bump mm2 version to 2.5.2-beta (#2638) feat(ci): add macos universal2 build (#2628) fix(metrics): remove memory_db size metric (#2632) fix(zcoin): exact-anchor witnesses in wasm get_spendable_notes (#2629) fix(evm-swapv2): no mempool inclusion required for maker payment validation (#2618) chore(rust 1.90): make CI clippy/fmt pass Revert "fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580)" Revert "fix(orderbook): validate roots before commit (#2605)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
malloc_sizecauses a segfault in Linux ref. GLEECBTC/gleec-wallet#3166 (comment)I suspect this is because of using
Jemallocas the globall allocator in Linuxhttps://github.com/KomodoPlatform/komodo-defi-framework/blob/453b100238d154fba51da0f94cba967535af4056/mm2src/mm2_bin_lib/src/mm2_bin.rs#L9-L11 This results in
parity-util-memmalloc_sizepath calling glibc’s__malloc_usable_size. Calling glibc’s usable_size on jemalloc pointers can intermittently segfault.As a solution, memory db size metric is removed and
parity-util-memdependency as well.