add search spinner while waiting for search to run#2567
Merged
jermnelson merged 2 commits intomasterfrom Oct 2, 2020
Merged
Conversation
peetucket
force-pushed
the
2182-search-spinner
branch
10 times, most recently
from
19ae87e to
3a886aa
Compare
peetucket
force-pushed
the
2182-search-spinner
branch
from
3a886aa to
c635f1b
Compare
jermnelson
requested changes
Oct 2, 2020
Contributor
jermnelson
left a comment
jermnelson
left a comment
There was a problem hiding this comment.
Looks good but needs a feature test.
Contributor
Author
|
Updated a search feature test to look for the spinner |
peetucket
force-pushed
the
2182-search-spinner
branch
from
76a9999 to
68f7e57
Compare
peetucket
force-pushed
the
2182-search-spinner
branch
from
68f7e57 to
320a888
Compare
jermnelson
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why was this change made?
Addresses part of #2182 (search spinner)
Timeouts are in #2583
This is how the loading spinner looks: (Note: the "results loading" text is in a span that only shows for screen readers.)
How was this change tested?
Which documentation and/or configurations were updated?
None