Replace Get<float> by Get<double> in property parsing

With latest version of Boost (1.88), `Get<float>` raises "RuntimeError: bad
lexical cast: source type value could not be interpreted as target"
exception for floating point values that don't exactly fit `float` precision.

Such values can be very innocent-looking: for instance, 39.5978 cannot be
stored as is in a float, but will be stored as 39.597801, what will make
Boost raise, and give the impression the problem is random.

To fix it, the only solution was to parse floating point values as
double and then narrow it to float.

Author: howetuft

include/luxrays/core/epsilon_types.cl

@@ -22,9 +22,14 @@
 #define DEFAULT_EPSILON_MAX 1e-1f
 #define DEFAULT_EPSILON_STATIC 1e-5f
 
+#define DEFAULT_EPSILON_MIN_DBL 1e-5
+#define DEFAULT_EPSILON_MAX_DBL 1e-1
+#define DEFAULT_EPSILON_STATIC_DBL 1e-5
+
 // An epsilon that can be used as threshold for cos(theta). For instance:
 // if (Dot(N, LightDir) < DEFAULT_COS_EPSILON_STATIC) return Spectrum();
 #define DEFAULT_COS_EPSILON_STATIC 1e-4f
+#define DEFAULT_COS_EPSILON_STATIC_DBL 1e-4
 
 // This is about 1e-5f for values near 1.f
 #define DEFAULT_EPSILON_DISTANCE_FROM_VALUE 0x80u

include/luxrays/utils/utils.h

@@ -89,6 +89,10 @@ int isinf(T a) { return std::isinf(a); }
 #define INFINITY (std::numeric_limits<float>::infinity())
 #endif
 
+#ifndef INFINITY_DBL
+#define INFINITY_DBL (std::numeric_limits<double>::infinity())
+#endif
+
 #ifndef INV_PI
 #define INV_PI  0.31830988618379067154f
 #endif

src/luxcore/luxparser/luxparse.cpp

@@ -53,7 +53,7 @@ BVHParams BVHAccel::ToBVHParams(const Properties &props) {
 	const int costSamples = props.Get(Property("accelerator.bvh.costsamples")(0)).Get<int>();
 	const int isectCost = props.Get(Property("accelerator.bvh.isectcost")(80)).Get<int>();
 	const int travCost = props.Get(Property("accelerator.bvh.travcost")(10)).Get<int>();
-	const float emptyBonus = props.Get(Property("accelerator.bvh.emptybonus")(.5)).Get<float>();
+	const float emptyBonus = props.Get(Property("accelerator.bvh.emptybonus")(.5)).Get<double>();
 
 	BVHParams params;
 	// Make sure treeType is 2, 4 or 8

src/luxcore/luxparser/luxparse.y

@@ -282,7 +282,7 @@ template<> float PropertyValue::Get<float>() const {
 		case BLOB_VAL:
 			throw std::runtime_error("A Blob property can not be converted to other types");
 		default:
-			throw std::runtime_error("Unknown type in PropertyValue::Get<float>(): " + ToString(dataType));
+			throw std::runtime_error("Unknown type in PropertyValue::Get<double>(): " + ToString(dataType));
 	}
 }
 
@@ -575,41 +575,41 @@ template<> const Blob &Property::Get<const Blob &>() const {
 template<> UV Property::Get<UV>() const {
 	if (values.size() != 2)
 		throw runtime_error("Wrong number of values in property: " + name);
-	return UV(Get<float>(0), Get<float>(1));
+	return UV(Get<double>(0), Get<double>(1));
 }
 
 template<> Vector Property::Get<Vector>() const {
 	if (values.size() != 3)
 		throw runtime_error("Wrong number of values in property: " + name);
-	return Vector(Get<float>(0), Get<float>(1), Get<float>(2));
+	return Vector(Get<double>(0), Get<double>(1), Get<double>(2));
 }
 
 template<> Normal Property::Get<Normal>() const {
 	if (values.size() != 3)
 		throw runtime_error("Wrong number of values in property: " + name);
-	return Normal(Get<float>(0), Get<float>(1), Get<float>(2));
+	return Normal(Get<double>(0), Get<double>(1), Get<double>(2));
 }
 
 template<> Point Property::Get<Point>() const {
 	if (values.size() != 3)
 		throw runtime_error("Wrong number of values in property: " + name);
-	return Point(Get<float>(0), Get<float>(1), Get<float>(2));
+	return Point(Get<double>(0), Get<double>(1), Get<double>(2));
 }
 
 template<> Spectrum Property::Get<Spectrum>() const {
 	if (values.size() != 3)
 		throw runtime_error("Wrong number of values in property: " + name);
-	return Spectrum(Get<float>(0), Get<float>(1), Get<float>(2));
+	return Spectrum(Get<double>(0), Get<double>(1), Get<double>(2));
 }
 
 template<> Matrix4x4 Property::Get<Matrix4x4>() const {
 	if (values.size() != 16)
 		throw runtime_error("Wrong number of values in property: " + name);
 	return Matrix4x4(
-			Get<float>(0), Get<float>(4), Get<float>(8), Get<float>(12),
-			Get<float>(1), Get<float>(5), Get<float>(9), Get<float>(13),
-			Get<float>(2), Get<float>(6), Get<float>(10), Get<float>(14),
-			Get<float>(3), Get<float>(7), Get<float>(11), Get<float>(15));
+			Get<double>(0), Get<double>(4), Get<double>(8), Get<double>(12),
+			Get<double>(1), Get<double>(5), Get<double>(9), Get<double>(13),
+			Get<double>(2), Get<double>(6), Get<double>(10), Get<double>(14),
+			Get<double>(3), Get<double>(7), Get<double>(11), Get<double>(15));
 }
 
 //------------------------------------------------------------------------------

src/luxrays/accelerators/bvhaccel.cpp

@@ -81,8 +81,8 @@ void ColorSpaceConfig::FromProperties(const Properties &props, const string &pre
 		case ColorSpaceConfig::LUXCORE_COLORSPACE: {
 			colorSpaceCfg.colorSpaceType = LUXCORE_COLORSPACE;
 			// For compatibility with the past
-			const float oldGamma = props.Get(Property(prefix + ".gamma")(defaultCfg.luxcore.gamma)).Get<float>();
-			colorSpaceCfg.luxcore.gamma = props.Get(Property(prefix + ".colorspace.gamma")(oldGamma)).Get<float>();
+			const float oldGamma = props.Get(Property(prefix + ".gamma")(defaultCfg.luxcore.gamma)).Get<double>();
+			colorSpaceCfg.luxcore.gamma = props.Get(Property(prefix + ".colorspace.gamma")(oldGamma)).Get<double>();
 			break;
 		}
 		case ColorSpaceConfig::OPENCOLORIO_COLORSPACE: {

src/luxrays/utils/properties.cpp

@@ -51,7 +51,7 @@ BakeCPURenderEngine::BakeCPURenderEngine(const RenderConfig *rcfg) :
 	skipExistingMapFiles = cfg.Get(Property("bake.skipexistingmapfiles")(false)).Get<bool>();
 
 	marginPixels = Max(cfg.Get(Property("bake.margin")(0u)).Get<u_int>(), 0u);
-	marginSamplesThreshold = Max(cfg.Get(Property("bake.marginsamplesthreshold")(0.f)).Get<float>(), 0.f);
+	marginSamplesThreshold = Max(cfg.Get(Property("bake.marginsamplesthreshold")(0.0)).Get<double>(), 0.0);
 
 	// Read the list of bake maps to render
 	vector<string> mapKeys = cfg.GetAllUniqueSubNames("bake.maps");

src/slg/core/colorspace.cpp

@@ -67,18 +67,18 @@ void BiDirCPURenderEngine::StartLockLess() {
 	maxLightPathDepth = (u_int)Max(1, cfg.Get(GetDefaultProps().Get("light.maxdepth")).Get<int>());
 
 	rrDepth = (u_int)Max(1, cfg.Get(GetDefaultProps().Get("path.russianroulette.depth")).Get<int>());
-	rrImportanceCap = Clamp(cfg.Get(GetDefaultProps().Get("path.russianroulette.cap")).Get<float>(), 0.f, 1.f);
+	rrImportanceCap = Clamp(cfg.Get(GetDefaultProps().Get("path.russianroulette.cap")).Get<double>(), 0.0, 1.0);
 
 	// Clamping settings
 	// clamping.radiance.maxvalue is the old radiance clamping, now converted in variance clamping
-	sqrtVarianceClampMaxValue = cfg.Get(Property("path.clamping.radiance.maxvalue")(0.f)).Get<float>();
+	sqrtVarianceClampMaxValue = cfg.Get(Property("path.clamping.radiance.maxvalue")(0.0)).Get<double>();
 	if (cfg.IsDefined("path.clamping.variance.maxvalue"))
-		sqrtVarianceClampMaxValue = cfg.Get(GetDefaultProps().Get("path.clamping.variance.maxvalue")).Get<float>();
+		sqrtVarianceClampMaxValue = cfg.Get(GetDefaultProps().Get("path.clamping.variance.maxvalue")).Get<double>();
 	sqrtVarianceClampMaxValue = Max(0.f, sqrtVarianceClampMaxValue);
 
 	// Albedo AOV settings
 	albedoSpecularSetting = String2AlbedoSpecularSetting(cfg.Get(GetDefaultProps().Get("path.albedospecular.type")).Get<string>());
-	albedoSpecularGlossinessThreshold = Max(cfg.Get(GetDefaultProps().Get("path.albedospecular.glossinessthreshold")).Get<float>(), 0.f);
+	albedoSpecularGlossinessThreshold = Max(cfg.Get(GetDefaultProps().Get("path.albedospecular.glossinessthreshold")).Get<double>(), 0.0);
 
 	//--------------------------------------------------------------------------
 	// Restore render state if there is one

src/slg/engines/bakecpu/bakecpu.cpp

@@ -37,8 +37,8 @@ void BiDirVMCPURenderEngine::StartLockLess() {
 	//--------------------------------------------------------------------------
 
 	lightPathsCount = Max(1024u, cfg.Get(GetDefaultProps().Get("bidirvm.lightpath.count")).Get<u_int>());
-	baseRadius = cfg.Get(GetDefaultProps().Get("bidirvm.startradius.scale")).Get<float>() * renderConfig->scene->dataSet->GetBSphere().rad;
-	radiusAlpha = cfg.Get(GetDefaultProps().Get("bidirvm.alpha")).Get<float>();
+	baseRadius = cfg.Get(GetDefaultProps().Get("bidirvm.startradius.scale")).Get<double>() * renderConfig->scene->dataSet->GetBSphere().rad;
+	radiusAlpha = cfg.Get(GetDefaultProps().Get("bidirvm.alpha")).Get<double>();
 
 	BiDirCPURenderEngine::StartLockLess();
 }