Dockerfile for ruby#276
Conversation
| await Promise.all(Object.keys(DOCKER_FILE_TYPES).map((fileName) => { | ||
| // don't generate docker-compose files for .NET Core apps | ||
| if (platformType.toLowerCase().includes('.net') && !fileName.includes('docker-compose')) { | ||
| if (platformType.toLowerCase().includes('.net') && fileName.includes('docker-compose')) { |
There was a problem hiding this comment.
FYI thanks for noticing! Fix already merged, even though you got to it sooner. :-)
MiguelSavignano
left a comment
There was a problem hiding this comment.
add ruby in pickplatform
|
Thanks. When we get issues and PRs filed against the Ruby dockerfile, are you willing to help review them? I won't have the expertise to do so. Also, do you mind adding some Ruby tests to the (new) configure.test.ts file (you'll have to merge to get it)? Plenty of examples in there. I could do this if you prefer. thx, |
|
I would be happy to help with issues or PRs. very soon I add test in configure.test.ts. |
|
@MiguelSavignano Thanks, much appreciated. Note that we'll need this within a couple of days if you want it to go out with the next release. |
|
@StephenWeatherford I add tests similar to those for python, and resolve conflicts with master branch |
|
@MiguelSavignano Perfect, thanks again! |
Generate basic Dockerfile for Ruby lang