Skip to content

Dockerfile for ruby#276

Merged
StephenWeatherford merged 6 commits intomicrosoft:masterfrom
MiguelSavignano:add-generate-ruby
Jul 24, 2018
Merged

Dockerfile for ruby#276
StephenWeatherford merged 6 commits intomicrosoft:masterfrom
MiguelSavignano:add-generate-ruby

Conversation

@MiguelSavignano
Copy link
Contributor

@MiguelSavignano MiguelSavignano commented Jun 9, 2018

Generate basic Dockerfile for Ruby lang

FROM ruby:2.5-slim

LABEL Name=${serviceName} Version=${version}
EXPOSE ${port}

# throw errors if Gemfile has been modified since Gemfile.lock
RUN bundle config --global frozen 1

WORKDIR /app
COPY . /app

COPY Gemfile Gemfile.lock ./
RUN bundle install

CMD ["ruby", "${serviceName}.rb"]

@msftclas
Copy link

msftclas commented Jun 9, 2018

CLA assistant check
All CLA requirements met.

await Promise.all(Object.keys(DOCKER_FILE_TYPES).map((fileName) => {
// don't generate docker-compose files for .NET Core apps
if (platformType.toLowerCase().includes('.net') && !fileName.includes('docker-compose')) {
if (platformType.toLowerCase().includes('.net') && fileName.includes('docker-compose')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI thanks for noticing! Fix already merged, even though you got to it sooner. :-)

Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seems like it needs to add Ruby as an option in quickPickPlatform in config-utils.ts? Let me know if you'd like me to take care of this.

Copy link
Contributor Author

@MiguelSavignano MiguelSavignano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ruby in pickplatform

@StephenWeatherford
Copy link
Contributor

Thanks. When we get issues and PRs filed against the Ruby dockerfile, are you willing to help review them? I won't have the expertise to do so.

Also, do you mind adding some Ruby tests to the (new) configure.test.ts file (you'll have to merge to get it)? Plenty of examples in there. I could do this if you prefer.

thx,
Stephen

@MiguelSavignano
Copy link
Contributor Author

I would be happy to help with issues or PRs.

very soon I add test in configure.test.ts.

@StephenWeatherford
Copy link
Contributor

@MiguelSavignano Thanks, much appreciated. Note that we'll need this within a couple of days if you want it to go out with the next release.

@MiguelSavignano
Copy link
Contributor Author

@StephenWeatherford I add tests similar to those for python, and resolve conflicts with master branch

@StephenWeatherford StephenWeatherford merged commit 9ca2f35 into microsoft:master Jul 24, 2018
@StephenWeatherford
Copy link
Contributor

@MiguelSavignano Perfect, thanks again!

@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants