[.NET Core Debugging] Add support for Alpine images#771
Merged
philliphoff merged 5 commits intomasterfrom Feb 14, 2019
Merged
Conversation
Member
Author
|
Resolves #765. |
Contributor
StephenWeatherford
left a comment
StephenWeatherford
left a comment
There was a problem hiding this comment.
Have you added a test case for CTI?
Member
Author
|
@StephenWeatherford Thanks for the reminder; I've added a variant of the main scenario but with Alpine-based images. |
Contributor
|
Thx. |
StephenWeatherford
approved these changes
Feb 14, 2019
gdziadkiewicz
added a commit
to gdziadkiewicz/vscode-docker
that referenced
this pull request
Feb 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for debugging Linux images based on the "Alpine" set of .NET Core base images.
Alpine images require a different variant of the .NET Core debugger (
vsdbg) than used for the "standard" images currently supported. Determining which variant is necessary must be done after the container is running, by executing a script on the container which returns the image type.Currently, the debugging provider volume mounts only the folder of a specific variant of debugger, and has the debugging engine use that variant. This change updates the debugging provider such that containers volume mount the root folder for all cached debugging variants (as that must happen during container creation), then starts the container, then runs the script to determine the needed variant, and then has the debugging engine use that variant. Because the volume mount is the root of the debugger cache, the container can use any of the cached variants as needed.