Check if .vscode/settings.json exists before trying to update test settings

[yajo]

Issue Type: Bug

I'm using a workspace with multiple folders. One of them is a subfolder of another folder. It seems like this extension fails to find a .vscode/settings.json file and produces this error log in the console:

Exception

[Extension Host] Error Python Extension: 2020-04-23 12:00:45: Failed to check if file needs to be fixed [EntryNotFound (FileSystemError): No se puede leer el archivo "/home/yajo/Documentos/prodevel/myproject-odoo/odoo/custom/src/private/.vscode/settings.json" (EntryNotFound (FileSystemError): Error: ENOENT: no such file or directory, open '/home/yajo/Documentos/prodevel/myproject-odoo/odoo/custom/src/private/.vscode/settings.json')
	at _handleError (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:617:941)
	at async v.readText (/home/yajo/.vscode/extensions/ms-python.python-2020.4.74986/out/client/extension.js:1:429153)
	at async h.doesFileNeedToBeFixed (/home/yajo/.vscode/extensions/ms-python.python-2020.4.74986/out/client/extension.js:75:1360230)
	at async /home/yajo/.vscode/extensions/ms-python.python-2020.4.74986/out/client/extension.js:75:1359232
	at async Promise.all (index 1)
	at async h.getFilesToBeFixed (/home/yajo/.vscode/extensions/ms-python.python-2020.4.74986/out/client/extension.js:75:1359178)
	at async h.updateTestSettings (/home/yajo/.vscode/extensions/ms-python.python-2020.4.74986/out/client/extension.js:75:1358805)] {
  code: 'FileNotFound',
  name: 'EntryNotFound (FileSystemError)'
}

I haven't noticed any problem related to this in the UI, but I guess this shouldn't be an unexpected scenario.

Extension version: 2020.4.74986
VS Code version: Code 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-16T17:50:03.709Z)
OS version: Linux x64 5.5.15-200.fc31.x86_64

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 4000)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: disabled_software skia_renderer: disabled_off_ok video_decode: unavailable_off viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	1, 1, 2
Memory (System)	15.48GB (0.71GB free)
Process Argv	--no-sandbox --unity-launch
Screen Reader	no
VM	0%

[kimadeline]

Hi @yajo,

Thank you for reporting this. The code that throws this error goes through your settings keys to see if they should be updated, and during this process adds {workspaceFolder}/.vscode/settings.json to the list of files that need to be checked, without verifying that the file exists first.

This shouldn't have any impact on your experience with the extension.

---

🏗️ Todo:

Verify that {workspaceFolder}/.vscode/settings.json exists before pushing it to the list of settings files to be checked.

vscode-python/src/client/testing/common/updateTestSettings.ts

Lines 37 to 39 in 61b179b

	if (workspaceFolder) {
	settingsFiles.push(path.join(workspaceFolder.uri.fsPath, '.vscode', 'settings.json'));
	}