-
Notifications
You must be signed in to change notification settings - Fork 38.5k
Closed
Labels
*as-designedDescribed behavior is as designedDescribed behavior is as designeddebugDebug viewlet, configurations, breakpoints, adapter issuesDebug viewlet, configurations, breakpoints, adapter issues
Milestone
Description
Insiders: 1.18.0-insider Commit: 154498 Date: 2017-11-02
The docker extension contributes the following in package.json:
"debuggers": [
{
"type": "docker",
"label": "Docker Attach",
"initialConfigurations": "vscode-docker.debug.configureLaunchJson"
}
],and in the activation of the extension it registers the vscode-docker.debug.configureLaunchJson command:
ctx.subscriptions.push(vscode.commands.registerCommand('vscode-docker.debug.configureLaunchJson', configureLaunchJson));When configuring a new workspace the command is not called, instead this is generated:
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": "vscode-docker.debug.configureLaunchJson"
}On Stable the command is executed and the following is generated:
{
"version": "0.2.0",
"configurations": [
{
"name": "Docker: Attach to Node",
"type": "node",
"request": "attach",
"port": 9229,
"address": "localhost",
"localRoot": "${workspaceRoot}",
"remoteRoot": "/usr/src/app"
}
]
}So, its appears broken on Insiders only and is a regression. Not sure how many other extensions do the same contribution.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
*as-designedDescribed behavior is as designedDescribed behavior is as designeddebugDebug viewlet, configurations, breakpoints, adapter issuesDebug viewlet, configurations, breakpoints, adapter issues