Skip to content

Commit 29ede5c

Browse files
DedeHaisofthack007
authored andcommitted
bugfix: do not reset segments if unchanged wled#4969
lines were swapped, causing segment reset on every preset call.
1 parent 4238e8f commit 29ede5c

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

wled00/FX_fcn.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@ void Segment::setUp(uint16_t i1, uint16_t i2, uint8_t grp, uint8_t spc, uint16_t
537537

538538
stateChanged = true; // send UDP/WS broadcast
539539

540-
if (stop>start) markForBlank(); //turn old segment range off // WLEDMM stop > start
540+
if (stop>start) markForBlank(); //turn old segment range off // WLEDMM stop > start // toDo: check if this can be skipped when boundsUnchanged
541541
if (i2 <= i1) { //disable segment
542542
stop = 0;
543543
markForReset();
@@ -558,8 +558,11 @@ void Segment::setUp(uint16_t i1, uint16_t i2, uint8_t grp, uint8_t spc, uint16_t
558558
spacing = spc;
559559
}
560560
if (ofs < UINT16_MAX) offset = ofs;
561-
markForReset();
562-
if (!boundsUnchanged) refreshLightCapabilities();
561+
562+
if (!boundsUnchanged) {
563+
markForReset();
564+
refreshLightCapabilities();
565+
}
563566
}
564567

565568

0 commit comments

Comments
 (0)