Skip to content

Commit 596d3eb

Browse files
committed
Remove outdated TP restriction for zero_outside_topk
Signed-off-by: Zhaopeng Qiu <qiuzhaopeng@foxmail.com>
1 parent c330f2d commit 596d3eb

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

nemo_rl/algorithms/distillation.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -153,13 +153,7 @@ def setup(
153153
assert generation_config is not None, (
154154
"A generation config in the PolicyConfig is required for distillation"
155155
)
156-
assert ( # [TODO] we may support this for tp in the future
157-
not loss_config.get("zero_outside_topk", False)
158-
or (policy_config["dtensor_cfg"]["tensor_parallel_size"] == 1)
159-
), (
160-
f"zero_outside_topk=True requires tensor_parallel_size=1, "
161-
f"but got tensor_parallel_size={policy_config['dtensor_cfg']['tensor_parallel_size']}. "
162-
)
156+
163157
# Set random seed
164158
set_seed(distillation_config["seed"])
165159

0 commit comments

Comments
 (0)