Skip to content

Commit a46c60c

Browse files
committed
fix some config issues uncovered by placing configs in the correct dir
Signed-off-by: Terry Kong <terryk@nvidia.com>
1 parent 8be415d commit a46c60c

4 files changed

Lines changed: 8 additions & 7 deletions

File tree

examples/configs/recipes/llm/grpo-deepscaler-1.5b-24K.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@ policy:
4545
gpu_memory_utilization: 0.8
4646
enforce_eager: True
4747
max_model_len: ${policy.max_total_sequence_length}
48-
# For most cases, use "dummy" to load the initial weights, since they will be overwritten during refit
49-
# For Gemma models, we need to use "auto" due to a vllm bug
50-
load_format: dummy
5148

5249
cluster:
5350
gpus_per_node: 8

examples/configs/recipes/llm/grpo-deepscaler-1.5b-8K.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ policy:
103103
gpu_memory_utilization: 0.6
104104
max_model_len: ${policy.max_total_sequence_length}
105105
enforce_eager: True
106-
# For most cases, use "dummy" to load the initial weights, since they will be overwritten during refit
107-
# For Gemma models, we need to use "auto" due to a vllm bug
108-
load_format: dummy
109106
colocated:
110107
# true: generation shares training GPUs
111108
# false: uses dedicated generation resources

tests/test_suites/nightly.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ tests/test_suites/llm/grpo-qwen2.5-7b-instruct-4n8g-fsdp2tp4sp.v3.sh
1313
# Functional 32b run
1414
tests/test_suites/llm/grpo-qwen2.5-32b-32n8g-fsdp2tp8sp-actckpt.v3.sh
1515

16+
# Deepscaler (short tests)
17+
tests/test_suites/llm/grpo-deepscaler-1.5b-16K.sh
18+
tests/test_suites/llm/grpo-deepscaler-1.5b-24K.sh
19+
tests/test_suites/llm/grpo-deepscaler-1.5b-8K.sh
20+
1621
#######
1722
# SFT #
1823
#######

tests/unit/test_recipes_and_test_suites.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,8 @@ def test_all_recipes_can_merge_configs_with_base_config(
283283
):
284284
from omegaconf import OmegaConf
285285

286+
from nemo_rl.utils.config import load_config
287+
286288
base_yaml = os.path.join(project_root, algo_base_yaml)
287289
base_config = OmegaConf.load(base_yaml)
288290
# Would result in an error if we couldn't merge our config with the recipe's config
@@ -293,7 +295,7 @@ def test_all_recipes_can_merge_configs_with_base_config(
293295
# test_all_recipes_start_with_algo_hyphen()
294296
continue
295297
recipe_yaml_path = os.path.join(recipes_dir, recipe_yaml)
296-
recipe_config = OmegaConf.load(recipe_yaml_path)
298+
recipe_config = load_config(recipe_yaml_path)
297299
OmegaConf.set_struct(recipe_config, True)
298300
# This will raise a error if the config can't be merged
299301
print(f"Merging {recipe_yaml} with {base_yaml}")

0 commit comments

Comments
 (0)