-
Notifications
You must be signed in to change notification settings - Fork 369
Add 2.6 dithering filter for viewer #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: RB-2.6
Are you sure you want to change the base?
Conversation
|
I'm pretty sure we already have software (Floyd Steinberg) dithering, and dithered tiles are cached in the viewer cache. Did you see that in the code? |
|
Oh, really, I haven't found any dithering code, maybe I overlooked it... This PR removes banding, though. I'll make a with/without image ASAP |
|
BTW, is there a release planned soon ? |
|
There's a typo in the shader code I fixed here : b992cd8 |
|
It seems that there's a dithering filter when working in 8 bits mode in the viewer, I didn't check that before, this patch remains valid as I can't find dithering filter in 32 bits mode |


Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Add a dithering filter to avoid color banding
Show a few screenshots (if this is a visual change)
[Your answer, delete this section if it is not a visual change.]
Have you tested your changes (if applicable)? If so, how?
Yes
Futher details of this pull request
Only works when the viewer is set to 32 bits FP