Skip to content

Commit 2414fef

Browse files
committed
python3Packages.chromadb: improve doCheck condition
On aarch64-linux onnxruntime cannot be imported, as it attempts to read /sys/devices/system/cpu, which does not exist in the sandbox. As onnxruntime cannot be imported, chromadb cannot be tested. However, this issue only applies in the build sandbox, not at runtime. Therefore the package doesn't need to be marked broken. Updated the condition to check `buildPlatform` instead of `hostPlatform`, as the issue relates to the build sandbox and is not a runtime issue. Use `isAarch` and `isLinux` attributes instead of doing string comparison. --- See #412528 (comment) And upstream onnxruntime issue: microsoft/onnxruntime#10038
1 parent 39a90ff commit 2414fef

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

pkgs/development/python-modules/chromadb/default.nix

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,10 +171,10 @@ buildPythonPackage rec {
171171

172172
# Disable on aarch64-linux due to broken onnxruntime
173173
# https://github.com/microsoft/onnxruntime/issues/10038
174-
pythonImportsCheck = lib.optionals (stdenv.hostPlatform.system != "aarch64-linux") [ "chromadb" ];
174+
pythonImportsCheck = lib.optionals doCheck [ "chromadb" ];
175175

176176
# Test collection breaks on aarch64-linux
177-
doCheck = stdenv.hostPlatform.system != "aarch64-linux";
177+
doCheck = with stdenv.buildPlatform; !(isAarch && isLinux);
178178

179179
env = {
180180
ZSTD_SYS_USE_PKG_CONFIG = true;

0 commit comments

Comments
 (0)