feat: Added option to send comment in Event#60
Merged
mpetrunic merged 1 commit intompetrunic:masterfrom Apr 3, 2023
masarykadam:add-comment-eventmessage
Merged
feat: Added option to send comment in Event#60mpetrunic merged 1 commit intompetrunic:masterfrom masarykadam:add-comment-eventmessage
mpetrunic merged 1 commit intompetrunic:masterfrom
masarykadam:add-comment-eventmessage
Conversation
masarykadam
changed the title
mpetrunic
approved these changes
Apr 3, 2023
Owner
mpetrunic
left a comment
mpetrunic
left a comment
There was a problem hiding this comment.
Hey, you are right, thank you!
This was referenced Apr 3, 2023
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
first of all thanks for library. I am using this lib to create simple push server to which clients can connect and will remain connected to receive message continuously. There may be one problem - underlying connection can get closed on any path to the client. I resolved this problem with periodically sending comment messages which do not fire handlers on client-side and keep connection alive.
This is what this PR helps with - allows users to send comments in event messages. According to specification line is treated as comment when it starts with
:symbol.