fix: 500 error on order by owner_company at orders repo

Author: smarcet

app/Repositories/ConfigDoctrineRepository.php

@@ -17,6 +17,7 @@
 use Doctrine\ORM\QueryBuilder;
 use LaravelDoctrine\ORM\Facades\Registry;
 use utils\Filter;
+use utils\Order;
 
 /**
  * Class ConfigDoctrineRepository
@@ -49,7 +50,7 @@ protected function applyExtraFilters(QueryBuilder $query)
      * @param QueryBuilder $query
      * @return QueryBuilder
      */
-    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null)
+    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null,  ?Order $order = null)
     {
         return $query;
     }

app/Repositories/DoctrineRepository.php

@@ -127,9 +127,10 @@ protected abstract function applyExtraFilters(QueryBuilder $query);
     /**
      * @param QueryBuilder $query
      * @param Filter|null $filter
-     * @return QueryBuilder
+     * @param Order|null $order
+     * @return mixed
      */
-    protected abstract function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null);
+    protected abstract function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null, ?Order $order = null);
 
     /**
      * @param QueryBuilder $query
@@ -161,7 +162,7 @@ protected function getParametrizedAllByPage
 
         $query  = call_user_func($fnQuery);
 
-        $query = $this->applyExtraJoins($query, $filter);
+        $query = $this->applyExtraJoins($query, $filter, $order);
 
         $query = $this->applyExtraSelects($query, $filter, $order);
 
@@ -224,7 +225,7 @@ public function getParametrizedAllIdsByPage(callable $fnQuery,PagingInfo $paging
 
         $query  = call_user_func($fnQuery);
 
-        $query = $this->applyExtraJoins($query, $filter);
+        $query = $this->applyExtraJoins($query, $filter, $order);
 
         $query = $this->applyExtraSelects($query, $filter, $order);
 
@@ -261,7 +262,7 @@ public function getAllByPage(PagingInfo $paging_info, Filter $filter = null, Ord
             ->select("e")
             ->from($this->getBaseEntity(), "e");
 
-        $query = $this->applyExtraJoins($query, $filter);
+        $query = $this->applyExtraJoins($query, $filter, $order);
 
         $query = $this->applyExtraSelects($query, $filter, $order);
 
@@ -310,7 +311,7 @@ public function getAllIdsByPage(PagingInfo $paging_info, Filter $filter = null,
             ->select("e.id")
             ->from($this->getBaseEntity(), "e");
 
-        $query = $this->applyExtraJoins($query, $filter);
+        $query = $this->applyExtraJoins($query, $filter, $order);
 
         $query = $this->applyExtraSelects($query, $filter, $order);
 

app/Repositories/Main/DoctrineAuditLogRepository.php

@@ -27,6 +27,7 @@
 use utils\DoctrineFilterMapping;
 use utils\DoctrineInstanceOfFilterMapping;
 use utils\Filter;
+use utils\Order;
 
 /**
  * Class DoctrineAuditLogRepository
@@ -49,7 +50,7 @@ protected function getBaseEntity()
      * @param Filter|null $filter
      * @return QueryBuilder
      */
-    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null): QueryBuilder
+    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null, ?Order $order = null): QueryBuilder
     {
         $query = $query->leftJoin(Member::class, 'u', 'WITH', 'e.user = u.id');
 

app/Repositories/Main/DoctrineExtraQuestionTypeRepository.php

@@ -22,6 +22,7 @@
 use utils\DoctrineCaseFilterMapping;
 use utils\DoctrineSwitchFilterMapping;
 use utils\Filter;
+use utils\Order;
 
 /**
  * Class DoctrineExtraQuestionTypeRepository
@@ -36,7 +37,7 @@ abstract class DoctrineExtraQuestionTypeRepository
      * @param QueryBuilder $query
      * @return QueryBuilder
      */
-    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null){
+    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null, ?Order $order = null){
         return $query;
     }
 

app/Repositories/Main/DoctrineProjectSponsorshipTypeRepository.php

@@ -16,6 +16,7 @@
 use Doctrine\ORM\QueryBuilder;
 use models\main\ProjectSponsorshipType;
 use utils\Filter;
+use utils\Order;
 
 /**
  * Class DoctrineProjectSponsorshipTypeRepository
@@ -45,7 +46,7 @@ protected function getFilterMappings()
      * @param QueryBuilder $query
      * @return QueryBuilder
      */
-    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null){
+    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null, ?Order $order = null){
         $query = $query->innerJoin("e.sponsored_project", "sp");
         return $query;
     }

app/Repositories/Main/DoctrineSummitAdministratorPermissionGroupRepository.php

@@ -16,6 +16,7 @@
 use Doctrine\ORM\QueryBuilder;
 use models\main\SummitAdministratorPermissionGroup;
 use utils\Filter;
+use utils\Order;
 
 /**
  * Class DoctrineSummitAdministratorPermissionGroupRepository
@@ -58,7 +59,7 @@ protected function getOrderMappings()
      * @param QueryBuilder $query
      * @return QueryBuilder
      */
-    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null)
+    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null, ?Order $order = null)
     {
         $query = $query->join('e.summits', 's')
             ->join('e.members', 'm');

app/Repositories/Main/DoctrineSupportingCompanyRepository.php

@@ -17,6 +17,7 @@
 use Doctrine\ORM\QueryBuilder;
 use models\main\SupportingCompany;
 use utils\Filter;
+use utils\Order;
 
 /**
  * Class DoctrineSupportingCompanyRepository
@@ -56,7 +57,7 @@ protected function getOrderMappings()
      * @param QueryBuilder $query
      * @return QueryBuilder
      */
-    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null)
+    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null, ?Order $order = null)
     {
         $query = $query->innerJoin("e.sponsorship_type", "st");
         $query = $query->innerJoin("e.company", "c");

app/Repositories/SilverStripeDoctrineRepository.php

@@ -18,6 +18,7 @@
 use models\utils\SilverstripeBaseModel;
 use LaravelDoctrine\ORM\Facades\Registry;
 use utils\Filter;
+use utils\Order;
 
 /**
  * Class SilverStripeDoctrineRepository
@@ -64,9 +65,11 @@ protected function applyExtraFilters(QueryBuilder $query){
 
     /**
      * @param QueryBuilder $query
+     * @param Filter|null $filter
+     * @param Order|null $order
      * @return QueryBuilder
      */
-    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null){
+    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null, ?Order $order = null){
         return $query;
     }
 

app/Repositories/Summit/DoctrineMemberRepository.php

@@ -54,7 +54,7 @@ protected function getBaseEntity()
      * @param Filter|null $filter
      * @return QueryBuilder
      */
-    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null): QueryBuilder
+    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null, ?Order $order = null): QueryBuilder
     {
         if($filter->hasFilter("summit_id") || $filter->hasFilter("schedule_event_id")){
             $query

app/Repositories/Summit/DoctrinePresentationActionTypeRepository.php

@@ -20,6 +20,7 @@
 use models\summit\PresentationActionType;
 use utils\DoctrineLeftJoinFilterMapping;
 use utils\Filter;
+use utils\Order;
 
 /**
  * Class DoctrinePresentationActionTypeRepository
@@ -43,7 +44,7 @@ protected function getBaseEntity(): string
      * @param Filter|null $filter
      * @return QueryBuilder
      */
-    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null): QueryBuilder
+    protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null, ?Order $order = null): QueryBuilder
     {
         return $query->leftJoin("e.assigned_selection_plans", "asp")
             ->leftJoin("asp.selection_plan", "sp");