fix: improve get tickets generic pagination

Author: smarcet

app/Repositories/DoctrineRepository.php

@@ -196,7 +196,7 @@ protected function getParametrizedAllByPage
         Log::debug(sprintf("DoctrineRepository::getParametrizedAllByPage DQL %s", $query->getDQL()));
         $start  = time();
 
-        $paginator = new Paginator($query, $fetchJoinCollection = true);
+        $paginator = new Paginator($query, $this->fetchJoinCollection);
         $total     = $paginator->count();
         $end = time();
         $delta = $end - $start;
@@ -290,7 +290,7 @@ public function getAllByPage(PagingInfo $paging_info, Filter $filter = null, Ord
             ->setFirstResult($paging_info->getOffset())
             ->setMaxResults($paging_info->getPerPage());
 
-        $paginator = new Paginator($query, $fetchJoinCollection = true);
+        $paginator = new Paginator($query, $this->fetchJoinCollection);
         $total     = $paginator->count();
         $data      = [];
 
@@ -307,6 +307,35 @@ public function getAllByPage(PagingInfo $paging_info, Filter $filter = null, Ord
         );
     }
 
+    /**
+     * @param Filter|null $filter
+     * @param Order|null $order
+     * @return int
+     */
+    public function getFastCount(Filter $filter = null, Order $order = null){
+        $query  = $this->getEntityManager()
+            ->createQueryBuilder()
+            ->distinct(true)
+            ->select('COUNT(DISTINCT e.id)')
+            ->from($this->getBaseEntity(), "e");
+
+        $query = $this->applyExtraJoins($query, $filter, $order);
+
+        $query = $this->applyExtraSelects($query, $filter, $order);
+
+        if(!is_null($filter)){
+            $filter->apply2Query($query, $this->getFilterMappings($filter));
+        }
+
+        $query = $this->applyExtraFilters($query);
+
+        if(!is_null($order)){
+            $order->apply2Query($query, $this->getOrderMappings($filter));
+        }
+
+        return (int) $query->getQuery()->getSingleScalarResult();
+    }
+
     /**
      * @param PagingInfo $paging_info
      * @param Filter|null $filter

app/Repositories/Summit/DoctrineSummitAttendeeTicketRepository.php

@@ -19,6 +19,7 @@
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\QueryBuilder;
+use Illuminate\Support\Facades\Log;
 use models\summit\IOrderConstants;
 use models\summit\ISummitAttendeeTicketRepository;
 use models\summit\ISummitRefundRequestConstants;
@@ -32,6 +33,7 @@
 use utils\Filter;
 use utils\Order;
 use utils\PagingInfo;
+use utils\PagingResponse;
 
 /**
  * Class DoctrineSummitAttendeeTicketRepository
@@ -89,7 +91,7 @@ private function ensureJoin(QueryBuilder $qb, string $alias): void
      */
     private function requiredAliases(?Filter $filter, ?Order $order): array
     {
-        $need = ['a' => true]; // owner always
+        $need = []; // owner always
 
         $has = fn(string $f) => $filter?->hasFilter($f) ?? false;
         $ord = fn(string $f) => $order?->hasOrder($f) ?? false;
@@ -425,10 +427,6 @@ protected function applyExtraJoins(QueryBuilder $query, ?Filter $filter = null,
             $this->ensureJoin($query, $alias);
         }
 
-        // owner is always selected to prevent N+1
-        if (\in_array('a', $query->getAllAliases(), true)) {
-            $query->addSelect('a'); // to-one fetch join is safe with pagination
-        }
 
         return $query;
     }
@@ -704,4 +702,45 @@ public function getAllTicketsIdsByOrder(int $order_id, PagingInfo $paging_info):
         $res = $query->getQuery()->getArrayResult();
         return array_column($res, 'id');
     }
+
+
+    /**
+     * @param PagingInfo $paging_info
+     * @param Filter|null $filter
+     * @param Order|null $order
+     * @return PagingResponse
+     */
+    public function getAllByPage(PagingInfo $paging_info, Filter $filter = null, Order $order = null){
+        $start = time();
+        Log::debug(sprintf('DoctrineSummitAttendeeTicketRepository::getAllByPage'));
+        $total = $this->getFastCount($filter, $order);
+        $ids = $this->getAllIdsByPage($paging_info, $filter, $order);
+        $query = $this->getEntityManager()->createQueryBuilder()
+                        ->select('e, a, o, tt, pc, b, bt, a_c, m')
+                    ->from($this->getBaseEntity(), 'e')
+                    ->leftJoin('e.owner', 'a')->addSelect('a')
+                    ->leftJoin('e.order', 'o')->addSelect('o')
+                    ->leftJoin('e.ticket_type', 'tt')->addSelect('tt')
+                    ->leftJoin('e.promo_code', 'pc')->addSelect('pc')
+                    ->leftJoin('e.badge', 'b')->addSelect('b')
+                    ->leftJoin('b.type', 'bt')->addSelect('bt')
+                    ->leftJoin('a.company', 'a_c')->addSelect('a_c')
+                    ->leftJoin('a.member', 'm')->addSelect('m')
+                    ->where('e.id IN (:ids)')
+                    ->setParameter('ids', $ids);
+
+        $data = [];
+        foreach( $query->getQuery()->getResult() as $entity)
+            array_push($data, $entity);
+        $end = time() - $start;
+        Log::debug(sprintf('DoctrineSummitAttendeeTicketRepository::getAllByPage %s seconds', $end));
+        return new PagingResponse
+        (
+            $total,
+            $paging_info->getPerPage(),
+            $paging_info->getCurrentPage(),
+            $paging_info->getLastPage($total),
+            $data
+        );
+    }
 }