[#3985] Refactor Routes with non returning methods (#3989)

* [#3985] Refactor Routes with non returning methods

* [#3985] Refactor Routes with non returning methods

Author: mustafaozhan

backend/app/src/main/kotlin/com/oztechan/ccc/backend/app/routes/CurrencyRoute.kt

@@ -17,14 +17,16 @@ private const val PARAMETER_BASE = "base"
 
 internal fun Route.getCurrencyByName(
     apiController: APIController
-) = get(PATH_BY_BASE) {
-    Logger.v { "GET Request $PATH_BY_BASE" }
+) {
+    get(PATH_BY_BASE) {
+        Logger.v { "GET Request $PATH_BY_BASE" }
 
-    call.parameters[PARAMETER_BASE]?.let { base ->
-        Logger.v { "Parameter: $PARAMETER_BASE $base" }
+        call.parameters[PARAMETER_BASE]?.let { base ->
+            Logger.v { "Parameter: $PARAMETER_BASE $base" }
 
-        apiController.getExchangeRateByBase(base)
-            ?.let { call.respond(HttpStatusCode.OK, it) }
-            ?: call.respond(HttpStatusCode.NotFound)
-    } ?: call.respond(HttpStatusCode.BadRequest)
+            apiController.getExchangeRateByBase(base)
+                ?.let { call.respond(HttpStatusCode.OK, it) }
+                ?: call.respond(HttpStatusCode.NotFound)
+        } ?: call.respond(HttpStatusCode.BadRequest)
+    }
 }

backend/app/src/main/kotlin/com/oztechan/ccc/backend/app/routes/ErrorRoute.kt

@@ -16,14 +16,16 @@ import io.ktor.server.routing.get
 private const val PATH_ERROR = "/error"
 private const val ERROR_HTML = "error.html"
 
-internal fun Route.getError() = get(PATH_ERROR) {
-    Logger.v { "GET Request $PATH_ERROR" }
+internal fun Route.getError() {
+    get(PATH_ERROR) {
+        Logger.v { "GET Request $PATH_ERROR" }
 
-    javaClass.classLoader?.getResource(ERROR_HTML)?.readText()?.let { resource ->
-        call.respondText(
-            text = resource,
-            contentType = ContentType.Text.Html,
-            status = HttpStatusCode.OK
-        )
-    } ?: call.respond(HttpStatusCode.NotFound)
+        javaClass.classLoader?.getResource(ERROR_HTML)?.readText()?.let { resource ->
+            call.respondText(
+                text = resource,
+                contentType = ContentType.Text.Html,
+                status = HttpStatusCode.OK
+            )
+        } ?: call.respond(HttpStatusCode.NotFound)
+    }
 }

backend/app/src/main/kotlin/com/oztechan/ccc/backend/app/routes/RootRoute.kt

@@ -16,14 +16,16 @@ import io.ktor.server.routing.get
 private const val PATH_ROOT = "/"
 private const val INDEX_HTML = "index.html"
 
-internal fun Route.getRoot() = get(PATH_ROOT) {
-    Logger.v { "GET Request $PATH_ROOT" }
+internal fun Route.getRoot() {
+    get(PATH_ROOT) {
+        Logger.v { "GET Request $PATH_ROOT" }
 
-    javaClass.classLoader?.getResource(INDEX_HTML)?.readText()?.let { resource ->
-        call.respondText(
-            text = resource,
-            contentType = ContentType.Text.Html,
-            status = HttpStatusCode.OK
-        )
-    } ?: call.respond(HttpStatusCode.NotFound)
+        javaClass.classLoader?.getResource(INDEX_HTML)?.readText()?.let { resource ->
+            call.respondText(
+                text = resource,
+                contentType = ContentType.Text.Html,
+                status = HttpStatusCode.OK
+            )
+        } ?: call.respond(HttpStatusCode.NotFound)
+    }
 }

backend/app/src/main/kotlin/com/oztechan/ccc/backend/app/routes/VersionRoute.kt

@@ -10,12 +10,14 @@ import io.ktor.server.routing.get
 
 private const val PATH_VERSION = "/version"
 
-internal fun Route.getVersion() = get(PATH_VERSION) {
-    Logger.v { "GET Request $PATH_VERSION" }
+internal fun Route.getVersion() {
+    get(PATH_VERSION) {
+        Logger.v { "GET Request $PATH_VERSION" }
 
-    call.respondText(
-        text = "Version: ${javaClass.`package`?.implementationVersion}",
-        contentType = ContentType.Text.Plain,
-        status = HttpStatusCode.OK
-    )
+        call.respondText(
+            text = "Version: ${javaClass.`package`?.implementationVersion}",
+            contentType = ContentType.Text.Plain,
+            status = HttpStatusCode.OK
+        )
+    }
 }