Fix exec_dialog to validate QDialog before deleting

PierreRaybaut · PierreRaybaut · commit 1a5314fe282a · 2026-02-26T09:55:39.000+01:00
diff --git a/doc/release_notes/release_3.14.md b/doc/release_notes/release_3.14.md
@@ -1,5 +1,11 @@
 # Version 3.14 #
 
+## guidata Version 3.14.3 ##
+
+🛠️ Bug fixes:
+
+* **PyQt6 compatibility**: Fixed `RuntimeError: wrapped C/C++ object has been deleted` when closing dialogs in automated tests with PyQt6 — `exec_dialog()` now checks object validity before calling `deleteLater()`, since Qt may already have destroyed the C++ object during `exec()`
+
 ## guidata Version 3.14.2 ##
 
 🛠️ Bug fixes:
diff --git a/guidata/qthelpers.py b/guidata/qthelpers.py
@@ -772,7 +772,7 @@ def exec_dialog(dlg: QW.QDialog) -> int:
         )
     delete_later = not dlg.testAttribute(QC.Qt.WA_DeleteOnClose)
     result = dlg.exec()
-    if delete_later:
+    if delete_later and is_qobject_valid(dlg):
         dlg.deleteLater()
     return result
 

Original file line number	Diff line number	Diff line change
`@@ -772,7 +772,7 @@ def exec_dialog(dlg: QW.QDialog) -> int:`
`772`	`772`	`)`
`773`	`773`	`delete_later = not dlg.testAttribute(QC.Qt.WA_DeleteOnClose)`
`774`	`774`	`result = dlg.exec()`
`775`		`- if delete_later:`
	`775`	`+ if delete_later and is_qobject_valid(dlg):`
`776`	`776`	`dlg.deleteLater()`
`777`	`777`	`return result`
`778`	`778`