Skip to content

Commit cddb231

Browse files
committed
Add requests into requirements-dev.txt
Optional import requests as API download is optional Signed-off-by: Isaac Yang <isaacy@nvidia.com>
1 parent 227d490 commit cddb231

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

monai/apps/mmars/mmars.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import warnings
2222
from typing import Mapping
2323

24-
import requests
2524
import torch
2625

2726
import monai.networks.nets as monai_nets
@@ -74,16 +73,20 @@ def _get_all_ngc_models(pattern, page_index=0, page_size=50):
7473
query_dict["filters"] = filter
7574
query_str = json.dumps(query_dict)
7675
full_url = f"{url}?q={query_str}"
77-
resp = requests.get(full_url)
76+
requests_get, has_requests = optional_import("requests", name="get")
77+
if has_requests:
78+
resp = requests_get(full_url)
79+
else:
80+
raise ValueError("NGC API requires requests package. Please install it.")
7881
model_list = json.loads(resp.text)
7982
model_dict = dict()
8083
for result in model_list["results"]:
8184
for model in result["resources"]:
82-
current_resId = model["resourceId"]
83-
model_dict[current_resId] = {"name": model["name"]}
85+
current_res_id = model["resourceId"]
86+
model_dict[current_res_id] = {"name": model["name"]}
8487
for attribute in model["attributes"]:
8588
if attribute["key"] == "latestVersionIdStr":
86-
model_dict[current_resId]["latest"] = attribute["value"]
89+
model_dict[current_res_id]["latest"] = attribute["value"]
8790
return model_dict
8891

8992

requirements-dev.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,4 @@ sphinx-rtd-theme==0.5.2
3434
cucim~=0.19.0; platform_system == "Linux"
3535
openslide-python==1.1.2
3636
pandas
37+
requests

0 commit comments

Comments
 (0)