Clear up job queue parameters in word2vec

[lunastera]

Fixes: #2928

Small job_queue related changes.

• Changed type information from (list of object, (str, int)) (or (list of object, (str, float))) to (list of object, float).
• The _get_job_params and _update_job_params are not properly named and have been replaced by _get_current_alpha and _update_alpha, respectively.
• Names like job_params have been replaced with alpha .
• The _update_job_params had job_params passed to it, which has been removed because it wasn't being used.

PS:

• Since _get_current_alpha and _update_alpha do essentially the same thing, they have been merged into _get_next_alpha.

[lunastera]

The py36-win test didn't pass, so I put back the unused argument and only changed the names. Why is this argument only needed in the py36-win environment?

[gojomo]

If you look at the actual test failure in the logs, it was not related to your changes. It's a test with some randomness that's occasionally failed, so that test-run was unlucky, and the later succeeding run was lucky, neither affected by your changes. (I just added some changes that may make it less flaky in #2930 - if you re-base on current develop it should minimize further distracting unrelated errors.)

[gojomo]

Looks like an improvement! But, having now looked at this more closely, the two different (current/update) methods seem redundant: they're both doing essentially the same thing. Want to take a try at going further, unifying them into one _get_next_alpha() method, that (at the outset) just considers current-epoch-progress as 0.0, & maybe even has simpler but consistent calculation-logic?

[mpenkov]

If this is an unused parameter, and the method is internal, perhaps it would be safe to get rid of the parameter?

[lunastera]

I will include a fix here as well.

[lunastera]

@gojomo I see! I understand about the test failing. Also, thanks for the further specific suggestions for improvement! That's certainly true, so I'll fix this as well.

[gojomo]

Looks good to me! (I'll leave it to either @mpenkov or @piskvorky to do final approval/application.)

[piskvorky]

Looks good.
Do any of the tutorials need updating after this API change? Did you / could you run a grep please?

[lunastera]

Thanks for the confirmation!
I did a grep on the changed variables and functions, but I didn't find any changes.

[piskvorky]

Awesome. Thanks :)