Deduplicate the data summarization code in the reporters #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdmarshall
force-pushed
the
json
branch
2 times, most recently
from
46e5f92 to
aea1584
Compare
Multiple reporters are using substantially the same logic.
Owner
|
I'll review that carefully tonight. Just came back from vacations. |
Collaborator
Author
|
I did a few captures and diffs and it seems to be in order. Though there are a couple places where CSV displays data one way and JSON another. Particularly the different units in the json output. It might be that since both of these will be consumed by software that perhaps they should be the same. |
RafaelGSS
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to figure out how to use the json reporter more like the html reporter, my eye was drawn back to some duplicated code my IDE has been complaining to me about for some time.
There's a spot in the code where the CSV format chose one fixed format and the json picked a 'human' format. I suspect Excel does not want to deal with a spread of units in a single column so that makes sense. But I sort of wonder if the same isn't also true of the json format. Why generate JSON if it is not meant to be consumed programatically instead of by humans?
This could be considered preparatory work for #119