chore: Standardize eslint typescript rules (#38584)

Author: KevLehman

apps/meteor/.eslintrc.json

@@ -1,5 +1,10 @@
 {
-	"extends": ["@rocket.chat/eslint-config", "@rocket.chat/eslint-config/react", "plugin:you-dont-need-lodash-underscore/compatible", "plugin:storybook/recommended"],
+	"extends": [
+		"@rocket.chat/eslint-config",
+		"@rocket.chat/eslint-config/react",
+		"plugin:you-dont-need-lodash-underscore/compatible",
+		"plugin:storybook/recommended"
+	],
 	"globals": {
 		"__meteor_bootstrap__": false,
 		"__meteor_runtime_config__": false,
@@ -94,15 +99,6 @@
 						}
 					}
 				],
-				"@typescript-eslint/no-misused-promises": [
-					"error",
-					{
-						"checksVoidReturn": {
-							"arguments": false
-						}
-					}
-				],
-				"@typescript-eslint/no-floating-promises": "error",
 				"no-unreachable-loop": "error"
 			},
 			"parserOptions": {

apps/meteor/.scripts/run-ha.ts

@@ -84,15 +84,15 @@ async function main(mode: any): Promise<void> {
 
 	switch (mode) {
 		case ModeParam.MAIN:
-			runMain(config);
+			void runMain(config);
 			break;
 		case ModeParam.INSTANCE:
-			runInstance(config);
+			void runInstance(config);
 			break;
 	}
 }
 
 // First two parameters are the executable and the path to this script
 const [, , mode] = process.argv;
 
-main(mode);
+void main(mode);

ee/apps/account-service/src/service.ts

@@ -6,7 +6,7 @@ import polka from 'polka';
 
 const PORT = process.env.PORT || 3033;
 
-(async () => {
+void (async () => {
 	const { db, client } = await getConnection();
 
 	startTracing({ service: 'account-service', db: client });

ee/apps/authorization-service/src/service.ts

@@ -7,7 +7,7 @@ import polka from 'polka';
 
 const PORT = process.env.PORT || 3034;
 
-(async () => {
+void (async () => {
 	const { db, client } = await getConnection();
 
 	startTracing({ service: 'authorization-service', db: client });

ee/apps/ddp-streamer/src/Client.ts

@@ -165,7 +165,7 @@ export class Client extends EventEmitter {
 				if (!packet.id) {
 					return this.ws.close(WS_ERRORS.CLOSE_PROTOCOL_ERROR);
 				}
-				this.callMethod(packet);
+				void this.callMethod(packet);
 				break;
 			case DDP_EVENTS.SUBSCRIBE:
 				if (!packet.name) {
@@ -174,7 +174,7 @@ export class Client extends EventEmitter {
 				if (!packet.id) {
 					return this.ws.close(WS_ERRORS.CLOSE_PROTOCOL_ERROR);
 				}
-				this.callSubscribe(packet);
+				void this.callSubscribe(packet);
 				break;
 			case DDP_EVENTS.UNSUBSCRIBE:
 				if (!packet.id) {

ee/apps/ddp-streamer/src/DDPStreamer.ts

@@ -66,7 +66,7 @@ export class DDPStreamer extends ServiceClass {
 
 	// update connections count every 30 seconds
 	updateConnections = throttle(() => {
-		InstanceStatus.updateConnections(this.wss?.clients.size ?? 0);
+		void InstanceStatus.updateConnections(this.wss?.clients.size ?? 0);
 	}, 30000);
 
 	override async created(): Promise<void> {
@@ -182,37 +182,37 @@ export class DDPStreamer extends ServiceClass {
 
 			server.emit('presence', { userId, connection });
 
-			this.api?.broadcast('accounts.login', { userId, connection });
+			void this.api?.broadcast('accounts.login', { userId, connection });
 		});
 
 		server.on(DDP_EVENTS.LOGGEDOUT, (info) => {
 			const { userId, connection } = info;
 
-			this.api?.broadcast('accounts.logout', { userId, connection });
+			void this.api?.broadcast('accounts.logout', { userId, connection });
 
-			this.updateConnections();
+			void this.updateConnections();
 
 			if (!userId) {
 				return;
 			}
-			Presence.removeConnection(userId, connection.id, nodeID);
+			void Presence.removeConnection(userId, connection.id, nodeID);
 		});
 
 		server.on(DDP_EVENTS.DISCONNECTED, (info) => {
 			const { userId, connection } = info;
 
-			this.api?.broadcast('socket.disconnected', connection);
+			void this.api?.broadcast('socket.disconnected', connection);
 
 			this.updateConnections();
 
 			if (!userId) {
 				return;
 			}
-			Presence.removeConnection(userId, connection.id, nodeID);
+			void Presence.removeConnection(userId, connection.id, nodeID);
 		});
 
 		server.on(DDP_EVENTS.CONNECTED, ({ connection }) => {
-			this.api?.broadcast('socket.connected', connection);
+			void this.api?.broadcast('socket.connected', connection);
 		});
 	}
 
@@ -258,7 +258,7 @@ export class DDPStreamer extends ServiceClass {
 
 			this.wss.on('connection', (ws, req) => new Client(ws, req.url !== '/websocket', req));
 
-			InstanceStatus.registerInstance('ddp-streamer', {});
+			void InstanceStatus.registerInstance('ddp-streamer', {});
 		} catch (err) {
 			console.error('DDPStreamer did not start correctly', err);
 		}

ee/apps/ddp-streamer/src/service.ts

@@ -6,7 +6,7 @@ import { registerServiceModels } from '@rocket.chat/models';
 import { startBroker } from '@rocket.chat/network-broker';
 import { startTracing } from '@rocket.chat/tracing';
 
-(async () => {
+void (async () => {
 	const { db, client } = await getConnection();
 
 	startTracing({ service: 'ddp-streamer', db: client });

ee/apps/omnichannel-transcript/src/service.ts

@@ -9,7 +9,7 @@ import { i18n } from './i18n';
 
 const PORT = process.env.PORT || 3036;
 
-(async () => {
+void (async () => {
 	const { db, client } = await getConnection();
 
 	startTracing({ service: 'omnichannel-transcript', db: client });

ee/apps/presence-service/src/service.ts

@@ -6,7 +6,7 @@ import polka from 'polka';
 
 const PORT = process.env.PORT || 3031;
 
-(async () => {
+void (async () => {
 	const { db, client } = await getConnection();
 
 	startTracing({ service: 'presence-service', db: client });

ee/apps/queue-worker/src/service.ts

@@ -7,7 +7,7 @@ import polka from 'polka';
 
 const PORT = process.env.PORT || 3038;
 
-(async () => {
+void (async () => {
 	const { db, client } = await getConnection();
 
 	startTracing({ service: 'queue-worker', db: client });