fix: Editing encrypted message attachment description (#37270)

Author: yash-rajpal

.changeset/healthy-colts-notice.md

@@ -0,0 +1,6 @@
+---
+'@rocket.chat/core-typings': patch
+'@rocket.chat/meteor': patch
+---
+
+Fixes editing of encrypted message attachment description.

apps/meteor/client/lib/parseMessageTextToAstMarkdown.ts

@@ -7,6 +7,7 @@ import {
 	isQuoteAttachment,
 	isTranslatedAttachment,
 	isTranslatedMessage,
+	isEncryptedMessageAttachment,
 } from '@rocket.chat/core-typings';
 import type { Options, Root } from '@rocket.chat/message-parser';
 import { parse } from '@rocket.chat/message-parser';
@@ -77,9 +78,10 @@ export const parseMessageAttachment = <T extends MessageAttachment>(
 		'';
 
 	if (isFileAttachment(attachment) && attachment.description) {
-		attachment.descriptionMd = translated
-			? textToMessageToken(text, parseOptions)
-			: (attachment.descriptionMd ?? textToMessageToken(text, parseOptions));
+		attachment.descriptionMd =
+			translated || isEncryptedMessageAttachment(attachment)
+				? textToMessageToken(text, parseOptions)
+				: (attachment.descriptionMd ?? textToMessageToken(text, parseOptions));
 	}
 
 	return {

apps/meteor/tests/e2e/e2e-encryption/e2ee-file-encryption.spec.ts

@@ -38,7 +38,7 @@ test.describe('E2EE File Encryption', () => {
 		await page.goto('/home');
 	});
 
-	test('File and description encryption', async ({ page }) => {
+	test('File and description encryption and editing the description', async ({ page }) => {
 		await test.step('create an encrypted channel', async () => {
 			const channelName = faker.string.uuid();
 
@@ -59,6 +59,18 @@ test.describe('E2EE File Encryption', () => {
 			await expect(poHomeChannel.content.getFileDescription).toHaveText('any_description');
 			await expect(poHomeChannel.content.lastMessageFileName).toContainText('any_file1.txt');
 		});
+
+		await test.step('edit the description', async () => {
+			await poHomeChannel.content.openLastMessageMenu();
+			await poHomeChannel.content.btnOptionEditMessage.click();
+
+			expect(await poHomeChannel.composer.inputValue()).toBe('any_description');
+
+			await poHomeChannel.content.inputMessage.fill('edited any_description');
+			await page.keyboard.press('Enter');
+
+			await expect(poHomeChannel.content.getFileDescription).toHaveText('edited any_description');
+		});
 	});
 
 	test('File encryption with whitelisted and blacklisted media types', async ({ page, api }) => {

packages/core-typings/src/IMessage/MessageAttachment/MessageAttachmentBase.ts

@@ -21,3 +21,11 @@ export type MessageAttachmentBase = {
 		sha256: string;
 	};
 };
+
+export type EncryptedMessageAttachment = MessageAttachmentBase & {
+	encryption: Required<MessageAttachmentBase>['encryption'];
+};
+
+export const isEncryptedMessageAttachment = (attachment: MessageAttachmentBase): attachment is EncryptedMessageAttachment => {
+	return attachment?.encryption !== undefined && typeof attachment.encryption === 'object';
+};