-
Notifications
You must be signed in to change notification settings - Fork 12.6k
fix: adjusts component params to match other charts #37340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 7474f14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughRemoved responsive width calculations from Omnichannel tag and department report components; BarChart margin values were adjusted to increase left spacing for labels. A changeset entry was added for the patch release. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37340 +/- ##
===========================================
+ Coverage 67.63% 68.14% +0.50%
===========================================
Files 3454 3364 -90
Lines 117006 115811 -1195
Branches 21247 20905 -342
===========================================
- Hits 79137 78919 -218
+ Misses 35169 34203 -966
+ Partials 2700 2689 -11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/meteor/client/omnichannel/reports/sections/TagsSection.tsx(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
apps/meteor/client/omnichannel/reports/sections/TagsSection.tsx (1)
apps/meteor/client/omnichannel/reports/components/BarChart.tsx (1)
BarChart(93-150)
🔇 Additional comments (1)
apps/meteor/client/omnichannel/reports/sections/TagsSection.tsx (1)
9-9: LGTM! Clean simplification.Removing the responsive width calculation simplifies the code and allows the chart to naturally fill its container width, which should help prevent label clipping.
apps/meteor/client/omnichannel/reports/sections/TagsSection.tsx
Outdated
Show resolved
Hide resolved
Fixes `Conversations by Tag` chart alignment to match similar charts in the `Reports` section of Omnichannel.
Proposed changes (including videos or screenshots)
This PR aims at fixing an issue where the
Conversations by Tagchart were clipping the tag name in a way it was difficult to read.I matched the Chart component params with the
Conversations by Departmentso it follows the same pattern.Issue(s)
CORE-225
Steps to test or reproduce
Further comments
Old:

New:

Summary by CodeRabbit