Skip to content

Conversation

@lucas-a-pelegrino
Copy link
Member

@lucas-a-pelegrino lucas-a-pelegrino commented Oct 29, 2025

Proposed changes (including videos or screenshots)

This PR aims at fixing an issue where the Conversations by Tag chart were clipping the tag name in a way it was difficult to read.

I matched the Chart component params with the Conversations by Department so it follows the same pattern.

Issue(s)

CORE-225

Steps to test or reproduce

Further comments

Old:
image-20240401-062933

New:
image

Summary by CodeRabbit

  • Style
    • Aligned the "Conversations by Tag" chart with other Omnichannel reports by adjusting margins and horizontal spacing for consistent presentation.
    • Simplified chart sizing behavior to rely on resize observations, improving visual consistency across report charts.

@lucas-a-pelegrino lucas-a-pelegrino added this to the 7.13.0 milestone Oct 29, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 29, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

🦋 Changeset detected

Latest commit: 7474f14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

Walkthrough

Removed responsive width calculations from Omnichannel tag and department report components; BarChart margin values were adjusted to increase left spacing for labels. A changeset entry was added for the patch release.

Changes

Cohort / File(s) Summary
Tag chart layout
apps/meteor/client/omnichannel/reports/sections/TagsSection.tsx
Removed contentBoxSize/inlineSize usage and width/maxWidth calculations from useResizeObserver; useResizeObserver now only returns a ref. Removed maxWidth usage for BarChart. Updated BarChart margins from { left: 40, top: 40, right: 20 } to { left: 92, top: 30, right: 8 }. No data or axis formatting changes.
Department chart margin
apps/meteor/client/omnichannel/reports/sections/DepartmentsSection.tsx
Adjusted BarChart left margin from 90 to 92; no other behavioral changes.
Release changelog
.changeset/swift-chefs-fail.md
Added a changeset entry for a patch release of @rocket.chat/meteor describing alignment fix for the "Conversations by Tag" chart.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Focused UI/layout changes in two components plus a changeset file.
  • Review attention:
    • TagsSection.tsx — confirm removing size reads and using only the ref doesn't regress label wrapping or accessibility on narrow screens.
    • DepartmentsSection.tsx — verify margin tweak doesn't introduce unexpected spacing.
    • Changeset file — confirm copy and versioning metadata.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • dougfabris

Poem

🐇 I hopped along the charted line,
I nudged the left so labels shine.
No more clipped names hiding in the dark,
Each tag now greets you — bright and stark. ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly summarizes the main change: adjusting component parameters in charts to ensure consistent alignment and labeling.
Linked Issues check ✅ Passed The PR addresses CORE-225 by adjusting BarChart margins in TagsSection to match DepartmentsSection, fixing the tag label clipping issue described in the issue.
Out of Scope Changes check ✅ Passed All changes are directly related to resolving the label rendering issue in CORE-225; margin adjustments in both TagsSection and DepartmentsSection are in scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/CORE-225

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ccd267f and ef8875a.

📒 Files selected for processing (1)
  • apps/meteor/client/omnichannel/reports/sections/DepartmentsSection.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: CodeQL-Build
🔇 Additional comments (1)
apps/meteor/client/omnichannel/reports/sections/DepartmentsSection.tsx (1)

14-14: Margins now consistent across chart sections.

Verified: TagsSection.tsx uses matching margins { left: 92, top: 30, right: 8 }. DepartmentsSection is now aligned with the fix applied to TagsSection, standardizing the left margin across Omnichannel report charts. The 2-unit increase is low-risk for existing functionality.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.14%. Comparing base (04b2549) to head (7474f14).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37340      +/-   ##
===========================================
+ Coverage    67.63%   68.14%   +0.50%     
===========================================
  Files         3454     3364      -90     
  Lines       117006   115811    -1195     
  Branches     21247    20905     -342     
===========================================
- Hits         79137    78919     -218     
+ Misses       35169    34203     -966     
+ Partials      2700     2689      -11     
Flag Coverage Δ
e2e 57.52% <100.00%> (+0.02%) ⬆️
unit 72.14% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucas-a-pelegrino lucas-a-pelegrino marked this pull request as ready for review October 30, 2025 19:12
@lucas-a-pelegrino lucas-a-pelegrino requested a review from a team as a code owner October 30, 2025 19:12
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1acf6a3 and ea3a0f1.

📒 Files selected for processing (1)
  • apps/meteor/client/omnichannel/reports/sections/TagsSection.tsx (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
apps/meteor/client/omnichannel/reports/sections/TagsSection.tsx (1)
apps/meteor/client/omnichannel/reports/components/BarChart.tsx (1)
  • BarChart (93-150)
🔇 Additional comments (1)
apps/meteor/client/omnichannel/reports/sections/TagsSection.tsx (1)

9-9: LGTM! Clean simplification.

Removing the responsive width calculation simplifies the code and allows the chart to naturally fill its container width, which should help prevent label clipping.

Fixes `Conversations by Tag` chart alignment to match similar charts in the `Reports` section of Omnichannel.
@lucas-a-pelegrino lucas-a-pelegrino requested a review from a team as a code owner November 6, 2025 14:20
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Nov 6, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 6, 2025
@kodiakhq kodiakhq bot merged commit 3310983 into develop Nov 6, 2025
167 of 171 checks passed
@kodiakhq kodiakhq bot deleted the bugfix/CORE-225 branch November 6, 2025 15:30
FelipeRDEV pushed a commit to FelipeRDEV/Rocket.Chat that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants