Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Nov 14, 2025

Proposed changes (including videos or screenshots)

Moves the expandable message composer out of feature preview

Issue(s)

CORE-1526

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • New Features
    • Expandable message composer is now available by default to all users.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 14, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2025

🦋 Changeset detected

Latest commit: a8b10e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 42 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/ui-client Major
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/gazzodown Major
@rocket.chat/ui-voip Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/uikit-playground Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/queue-worker Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/http-router Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence-service Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

Walkthrough

This PR graduates the expandable message composer feature from experimental preview to stable production status. The feature flag wrapper is removed from the component, feature preview references are eliminated from the codebase, and associated i18n keys are deleted. A changeset documents the version bumps for affected packages.

Changes

Cohort / File(s) Summary
Changeset Entry
.changeset/few-mirrors-smoke.md
Documents minor version bumps and notes the removal of expandable message composer from feature preview.
Message Box Component
apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx
Replaces conditional FeaturePreview-wrapped MessageComposerInput with unconditional MessageComposerInputExpandable; removes FeaturePreview imports.
Internationalization
packages/i18n/src/locales/en.i18n.json, packages/i18n/src/locales/nb.i18n.json
Removes Expandable_message_composer and Expandable_message_composer_description translation keys.
Feature Preview Hook
packages/ui-client/src/hooks/useFeaturePreviewList.ts
Removes 'expandableMessageComposer' from FeaturesAvailable union type and deletes its entry from defaultFeaturesPreview array.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Changes follow a consistent pattern: removal of feature flag references across multiple files
  • No complex logic modifications; primarily housekeeping and cleanup
  • Changes are homogeneous (all tied to graduating one feature), reducing cognitive load
  • Worth verifying: confirm all references to the feature are removed and that component behavior remains correct after unwrapping the feature preview conditional

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • dougfabris
  • yash-rajpal

Poem

🐰 From preview's nest, the composer takes flight,
No longer behind a preview wall so tight,
Expandable, stable, now ready for all,
The feature preview list heard graduation's call! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: moving the expandable message composer from feature preview status to stable production code.
Linked Issues check ✅ Passed The changes align with CORE-1347 objectives by stabilizing the expandable message composer feature and removing it from feature preview status for release.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objective of moving the expandable message composer out of feature preview, with no extraneous modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/expandable-composer-feat-previ

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MartinSchoeler MartinSchoeler added this to the 7.13.0 milestone Nov 14, 2025
Moves the expandable message composer out of feature preview
@MartinSchoeler MartinSchoeler marked this pull request as ready for review November 17, 2025 12:15
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner November 17, 2025 12:15
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.98%. Comparing base (0691514) to head (e14f0ce).
⚠️ Report is 11 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37524      +/-   ##
===========================================
+ Coverage    68.97%   68.98%   +0.01%     
===========================================
  Files         3358     3358              
  Lines       114240   114226      -14     
  Branches     20537    20535       -2     
===========================================
+ Hits         78792    78796       +4     
+ Misses       33359    33339      -20     
- Partials      2089     2091       +2     
Flag Coverage Δ
e2e 57.46% <100.00%> (+0.02%) ⬆️
e2e-api 42.85% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Nov 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 17, 2025
@github-actions
Copy link
Contributor

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 367MiB 355MiB +12MiB
omnichannel-transcript-service 141MiB 141MiB +2.0KiB
queue-worker-service 141MiB 141MiB -368B
ddp-streamer-service 127MiB 127MiB +514B
account-service 114MiB 114MiB +613B
stream-hub-service 111MiB 111MiB -1.4KiB
authorization-service 111MiB 111MiB -281B
presence-service 111MiB 111MiB -2.0KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 19:04", "11/17 20:16 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14]
  line "presence-service" [0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14]
  line "rocketchat" [0.36, 0.36, 0.35, 0.36]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 3 days):

  • 📊 Average: 1.4GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37524
  • Baseline: develop
  • Timestamp: 2025-11-17 20:16:16 UTC
  • Historical data points: 3

Updated: Mon, 17 Nov 2025 20:16:16 GMT

@ggazzo ggazzo merged commit 150efb9 into develop Nov 17, 2025
46 of 48 checks passed
@ggazzo ggazzo deleted the chore/expandable-composer-feat-previ branch November 17, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants