Revert use of match?. It was introduced on Ruby 2.4 and we keep compatibility with old versions

pitbulk · pitbulk · commit 779b7888cff0 · 2025-11-23T11:36:24.000+01:00
diff --git a/lib/onelogin/ruby-saml/saml_message.rb b/lib/onelogin/ruby-saml/saml_message.rb
@@ -136,7 +136,7 @@ def encode(string)
       # @return [true, false] whether or not the string is base64 encoded
       #
       def base64_encoded?(string)
-        string.gsub(/\s|\\r|\\n/, '').match?(BASE64_FORMAT)
+        !!string.gsub(/[\r\n]|\\r|\\n|\s/, "").match(BASE64_FORMAT)
       end
 
       # Attempt inflating a string, if it fails, return the original string.

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ def encode(string)`
`136`	`136`	`# @return [true, false] whether or not the string is base64 encoded`
`137`	`137`	`#`
`138`	`138`	`def base64_encoded?(string)`
`139`		`- string.gsub(/\s\|\\r\|\\n/, '').match?(BASE64_FORMAT)`
	`139`	`+ !!string.gsub(/[\r\n]\|\\r\|\\n\|\s/, "").match(BASE64_FORMAT)`
`140`	`140`	`end`
`141`	`141`
`142`	`142`	`# Attempt inflating a string, if it fails, return the original string.`