-
Notifications
You must be signed in to change notification settings - Fork 20
feat: DAH-3550 Priorities Checkbox Group #2738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| name={priorityMembers} | ||
| type="checkbox" | ||
| groupLabel={t(description)} | ||
| fields={[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: the Salesforce back-end expects specific string values, e.g. 'Mobility impairments' instead of 'mobilityImpairment'. See here. I would suggest creating an array in the constants.tsx file and importing it into this file.
jimlin-sfgov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Builds out the Priorities Checkbox group of fields component
Jira ticket
https://sfgovdt.jira.com/browse/DAH-3550
Before requesting eng review
Version Control
angularif it contains updates to Angular codetype: TICKET-NUMBER Descriptionformat, useDAH-000if it does not need a ticketurgent: Descriptionformat if it is urgent and does not need a ticketCode quality
Code conventions
.scssstylesheets andui-seedstokens, rather than inline styles or TailwindReview instructions
Request eng review
needs reviewlabelHousing Enggroup to automatically assign reviewers, and/or assign specific engineersBefore merging
Request product acceptance (PA) testing
needs product acceptancelabel)