Skip to content

Conversation

@jtcaovan
Copy link
Collaborator

@jtcaovan jtcaovan commented Nov 8, 2025

Description

Builds out the Priorities Checkbox group of fields component

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3550

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, use DAH-000 if it does not need a ticket
  • PR name follows urgent: Description format if it is urgent and does not need a ticket

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • if the PR is a bugfix, there are tests and logs around the bug

Code conventions

  • web pages are formatted with .scss stylesheets and ui-seeds tokens, rather than inline styles or Tailwind

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance (PA) testing

  • PA tested in the review environment (use needs product acceptance label)
  • if PA testing cannot be done, changes are behind a feature flag

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2738 November 8, 2025 01:32 Inactive
@jtcaovan jtcaovan added the needs review Pull request needs review label Nov 10, 2025
@jtcaovan jtcaovan requested review from a team, cliu02 and jimlin-sfgov and removed request for a team November 10, 2025 16:56
name={priorityMembers}
type="checkbox"
groupLabel={t(description)}
fields={[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: the Salesforce back-end expects specific string values, e.g. 'Mobility impairments' instead of 'mobilityImpairment'. See here. I would suggest creating an array in the constants.tsx file and importing it into this file.

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2738 November 13, 2025 22:50 Inactive
@hshaosf hshaosf had a problem deploying to dahlia-webapp-pr-2738 November 14, 2025 20:41 Failure
@hshaosf hshaosf had a problem deploying to dahlia-webapp-pr-2738 November 14, 2025 21:38 Failure
@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2738 November 17, 2025 18:20 Inactive
Copy link
Collaborator

@jimlin-sfgov jimlin-sfgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtcaovan jtcaovan added needs product acceptance Pull request requires product acceptance before merging and removed needs review Pull request needs review labels Nov 19, 2025
@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2738 December 3, 2025 20:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs product acceptance Pull request requires product acceptance before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants