Skip to content

Commit b613df7

Browse files
authored
Merge pull request #1755 from heinezen/doc/make_check
Change mentions of 'checkall' to 'checkmerge'
2 parents d7ee6a5 + 961d187 commit b613df7

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

.github/PULL_REQUEST_TEMPLATES/pull_request_template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
- [ ] I have read the [contribution guide](doc/contributing.md)
77
- [ ] I have added my info to [copying.md](copying.md) (only first time contributors)
8-
- [ ] I have run `make checkall` and fixed all mentioned problems
8+
- [ ] I have run `make checkmerge` and fixed all mentioned problems
99

1010

1111
### Description

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ help: $(BUILDDIR)/Makefile
179179
@echo "tests -> run the tests (py + cpp)"
180180
@echo ""
181181
@echo "checkall -> full code compliance check"
182+
@echo "checkmerge -> code compliance check for merging to master"
182183
@echo "checkfast -> fast checks only"
183184
@echo "checkchanged -> full check for all files changed since origin/master"
184185
@echo "checkuncommited -> full check for all currently uncommited files"

doc/buildsystem.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Additional recipes:
4242
- `doc` (generate docs via Doxygen)
4343
- `test` (runs the various tests)
4444
- various cleaning recipes: `cleanelf`, `cleancodegen`, `cleancython`, `cleaninsourcebuild`, `cleanpxdgen`, `cleanbuilddirs`, `mrproper`, `mrproperer`
45-
- various compliance checkers: `checkfast`, `checkall`, ...
45+
- various compliance checkers: `checkfast`, `checkmerge`, `checkall`, ...
4646

4747

4848
Phases

doc/contributing.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ tl;dr
5252
- Add yourself to `copying.md`
5353
- `git add libopenage/unit/tentacle_monster.cpp`
5454
- `git commit -m "engine: fixed vomiting animation of tentacle monster"`
55-
- `make checkall`
55+
- `make checkmerge`
5656
- `make test`
5757
- `git push origin tentacle-monster-fix`
5858
- Create a pull request and look at the CI output
@@ -101,7 +101,7 @@ Before making a pull request, it's good to review these things:
101101
- Run `make test` to check whether any functionality has been broken
102102
- [Check your whitespaces](https://github.com/SFTtech/openage/blob/master/doc/code_style/tabs_n_spaces.md)
103103
- [Read all the codestyle docs]( https://github.com/SFTtech/openage/tree/master/doc/code_style)
104-
- Before pushing, run `make checkall`. If that fails, the automatic buildbot will reject your code.
104+
- Before pushing, run `make checkmerge`. If that fails, the automatic buildbot will reject your code.
105105
- If this is your first contribution, add yourself to the authors list in [copying.md](/copying.md).
106106
- Commit messages should be meaningful, they should say in a sentence (or very little text) what
107107
changes it has without requiring to read the entire diff. [tpope knows this very well!](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)

doc/ide/configs/vscode/tasks.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"type": "shell",
5252
"command": "make",
5353
"args": [
54-
"checkall"
54+
"checkmerge"
5555
],
5656
"group": "build",
5757
"presentation": {

0 commit comments

Comments
 (0)