#105 Fix resize with n/s handles on locked aspect ratio#106
Merged
STRML merged 2 commits intoreact-grid-layout:masterfrom Oct 22, 2019
Merged
#105 Fix resize with n/s handles on locked aspect ratio#106STRML merged 2 commits intoreact-grid-layout:masterfrom
STRML merged 2 commits intoreact-grid-layout:masterfrom
Conversation
Collaborator
|
Oh that's quite interesting. I see the issue, I wonder if there isn't a more elegant way to do this. |
Contributor
Author
|
@STRML I agree, updated the PR with a slight local code improvement. |
Collaborator
|
Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #105
Additional calculation of dimensions with locked aspect ratio starting from height change, not only width.