Skip to content

Conversation

@Purfview
Copy link
Contributor

Avoids appending extra window when audio length is already multiple of window_size_samples

Avoids appending extra window when audio length is already multiple of window_size_samples
@MahmoudAshraf97
Copy link
Collaborator

Any Idea why the CI fails? it seems unrelated, I also retried it multiple times

@Purfview
Copy link
Contributor Author

Any Idea why the CI fails? it seems unrelated, I also retried it multiple times

Lets check.

@Purfview
Copy link
Contributor Author

Purfview commented Oct 30, 2025

Capping huggingface_hub at <=0.19.4 solved that error.
It's capped at "0.19.4" in my env, I had some problems with some higher version, I don't remember what or why, I'll check what's going on.

EDIT:
Tested huggingface_hub 1.0.1, it downloaded models, looks like it doesn't import "requests" anymore, so I made a separate PR to address that.

But there is new error, so WIP...

Removed upper limit for huggingface_hub version.
Copy link
Collaborator

@MahmoudAshraf97 MahmoudAshraf97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging as the error is not related

@Purfview
Copy link
Contributor Author

Purfview commented Oct 30, 2025

So, what to do with this?

  1. Leave as it was. [Close PR]
  2. Return vad func after empty audio check.

@MahmoudAshraf97
Copy link
Collaborator

I say we leave it as it was, one more window never hurt anyone

@Purfview Purfview closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants