-
Notifications
You must be signed in to change notification settings - Fork 1.6k
VAD: Don't pad if padding is not needed #1379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Avoids appending extra window when audio length is already multiple of window_size_samples
|
Any Idea why the CI fails? it seems unrelated, I also retried it multiple times |
Lets check. |
|
Capping huggingface_hub at <=0.19.4 solved that error. EDIT: But there is new error, so WIP... |
MahmoudAshraf97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging as the error is not related
|
So, what to do with this?
|
|
I say we leave it as it was, one more window never hurt anyone |
Avoids appending extra window when audio length is already multiple of window_size_samples