Skip to content

Commit 28989f1

Browse files
authored
Merge pull request #506 from Shopify/modernize-ci-ruby-versions
Remove ruby 3.1 and add 4.0 to CI tests
2 parents c5b2c55 + d973966 commit 28989f1

File tree

6 files changed

+26
-20
lines changed

6 files changed

+26
-20
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ jobs:
99

1010
strategy:
1111
matrix:
12-
ruby: ['3.1', '3.2', '3.3', '3.4']
12+
ruby: ['3.2', '3.3', '3.4', '4.0']
1313

1414
name: Ruby ${{ matrix.ruby }}
1515
steps:
1616
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
1717
- name: Set up Ruby ${{ matrix.ruby }}
18-
uses: ruby/setup-ruby@e34163cd15f4bb403dcd72d98e295997e6a55798 # v1.238.0
18+
uses: ruby/setup-ruby@4fc31e1c823882afd7ef55985266a526c589de90 # v1.238.0
1919
with:
2020
ruby-version: ${{ matrix.ruby }}
2121
bundler-cache: true

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.4.2
1+
4.0.1

Gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
source "https://rubygems.org"
44

55
gem "pry-byebug", require: false
6+
gem "readline", require: false
67
gem "rubocop", require: false
78
gem "rubocop-shopify", ">=2.8.0", require: false
89
gem "rubocop-performance", require: false

Gemfile.lock

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,9 @@ GEM
134134
marcel (1.0.4)
135135
method_source (1.1.0)
136136
mini_mime (1.1.5)
137-
mini_portile2 (2.8.8)
138-
minitest (5.25.5)
137+
mini_portile2 (2.8.9)
138+
minitest (6.0.1)
139+
prism (~> 1.5)
139140
mutex_m (0.3.0)
140141
net-imap (0.5.7)
141142
date
@@ -147,18 +148,18 @@ GEM
147148
net-smtp (0.5.1)
148149
net-protocol
149150
nio4r (2.7.4)
150-
nokogiri (1.18.8)
151+
nokogiri (1.19.0)
151152
mini_portile2 (~> 2.8.2)
152153
racc (~> 1.4)
153-
nokogiri (1.18.8-aarch64-linux-gnu)
154+
nokogiri (1.19.0-aarch64-linux-gnu)
154155
racc (~> 1.4)
155-
nokogiri (1.18.8-arm-linux-gnu)
156+
nokogiri (1.19.0-arm-linux-gnu)
156157
racc (~> 1.4)
157-
nokogiri (1.18.8-arm64-darwin)
158+
nokogiri (1.19.0-arm64-darwin)
158159
racc (~> 1.4)
159-
nokogiri (1.18.8-x86_64-darwin)
160+
nokogiri (1.19.0-x86_64-darwin)
160161
racc (~> 1.4)
161-
nokogiri (1.18.8-x86_64-linux-gnu)
162+
nokogiri (1.19.0-x86_64-linux-gnu)
162163
racc (~> 1.4)
163164
ostruct (0.6.1)
164165
parallel (1.27.0)
@@ -168,7 +169,7 @@ GEM
168169
pp (0.6.2)
169170
prettyprint
170171
prettyprint (0.2.0)
171-
prism (1.4.0)
172+
prism (1.9.0)
172173
pry (0.15.2)
173174
coderay (~> 1.1)
174175
method_source (~> 1.0)
@@ -225,6 +226,8 @@ GEM
225226
logger
226227
rdoc (6.13.1)
227228
psych (>= 4.0.0)
229+
readline (0.0.4)
230+
reline
228231
regexp_parser (2.11.0)
229232
reline (0.6.1)
230233
io-console (~> 0.5)
@@ -269,12 +272,12 @@ GEM
269272
simplecov_json_formatter (~> 0.1)
270273
simplecov-html (0.13.1)
271274
simplecov_json_formatter (0.1.4)
272-
sqlite3 (2.6.0-aarch64-linux-gnu)
273-
sqlite3 (2.6.0-arm-linux-gnu)
274-
sqlite3 (2.6.0-arm64-darwin)
275-
sqlite3 (2.6.0-x86-linux-gnu)
276-
sqlite3 (2.6.0-x86_64-darwin)
277-
sqlite3 (2.6.0-x86_64-linux-gnu)
275+
sqlite3 (2.9.0-aarch64-linux-gnu)
276+
sqlite3 (2.9.0-arm-linux-gnu)
277+
sqlite3 (2.9.0-arm64-darwin)
278+
sqlite3 (2.9.0-x86-linux-gnu)
279+
sqlite3 (2.9.0-x86_64-darwin)
280+
sqlite3 (2.9.0-x86_64-linux-gnu)
278281
steep (1.10.0)
279282
activesupport (>= 5.1)
280283
concurrent-ruby (>= 1.1.10)
@@ -302,7 +305,7 @@ GEM
302305
concurrent-ruby (~> 1.0)
303306
unicode-display_width (3.1.4)
304307
unicode-emoji (~> 4.0, >= 4.0.4)
305-
unicode-emoji (4.0.4)
308+
unicode-emoji (4.2.0)
306309
uri (1.0.4)
307310
useragent (0.16.11)
308311
websocket-driver (0.7.7)
@@ -326,6 +329,7 @@ DEPENDENCIES
326329
pry-byebug
327330
rails (~> 7.2)
328331
rbs (~> 3.0)
332+
readline
329333
rspec (~> 3.2)
330334
rubocop
331335
rubocop-performance

money.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Gem::Specification.new do |s|
2828
s.add_development_dependency("simplecov", ">= 0")
2929
s.add_development_dependency("sqlite3")
3030

31-
s.required_ruby_version = '>= 3.1'
31+
s.required_ruby_version = '>= 3.2'
3232

3333
s.files = %x(git ls-files).split($/)
3434
s.executables = s.files.grep(%r{^bin/}) { |f| File.basename(f) }

spec/spec_helper.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
$LOAD_PATH.unshift(File.dirname(__FILE__))
1111

1212
require 'rspec'
13+
require 'readline'
1314
require 'pry-byebug'
1415
require 'database_cleaner'
1516
require 'ostruct'

0 commit comments

Comments
 (0)