Remove boilerplate executables from gemspec#479
Closed
hsbt wants to merge 1 commit intoShopify:mainfrom
Closed
Conversation
hsbt
force-pushed
the
remove-executable
branch
from
eae3d14 to
db11baa
Compare
Author
|
I signed CLA and rebase with the current HEAD commit. |
There was a problem hiding this comment.
Pull request overview
This PR removes the s.executables configuration from the gemspec to prevent development tools from being added to the user's PATH environment variable when the gem is installed. The bin/console file is a standard development helper script (using IRB) that should only be used by developers working on the gem itself, not by consumers of the gem.
Changes:
- Removed the
s.executablesline from money.gemspec that was automatically including all files in thebin/directory as executable commands
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Hi - there was another PR that fixed this. sorry didn't see yours at first. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It pollute
consolecommand toPATHenvironmental variable.