Skip to content

Commit 3c54ef5

Browse files
authored
Refactor downloads (#540)
* Sort CourseInfoTabSyllabus group * Swiftlint disable next discouraged_optional_collection * Deinit DispatchGroup's on notify to prevent unbalanced call to leave() * Execute syllabus Core Data fetch requests on main thread only * Use performAndWait * Update SwiftLint * Use new build system * Update pods * Fix profile userID block presentation * Update hasPlaceholderUnits * Add SyllabusDownloadsService
1 parent b18b9ed commit 3c54ef5

24 files changed

+1005
-686
lines changed

.swiftlint.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ included:
77

88
analyzer_rules:
99
- explicit_self
10-
- unused_private_declaration
10+
- unused_declaration
1111

1212
whitelist_rules:
1313
- array_init
@@ -117,7 +117,6 @@ whitelist_rules:
117117
- vertical_whitespace_closing_braces
118118
- vertical_whitespace_opening_braces
119119
- void_return
120-
- weak_computed_property
121120
- weak_delegate
122121
- yoda_condition
123122

Podfile

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,74 +1,74 @@
1-
# Uncomment this line to define a global platform for your project
21
install! 'cocoapods', :deterministic_uuids => false
32
source 'https://github.com/CocoaPods/Specs.git'
43

54
inhibit_all_warnings!
65
use_frameworks!
76

87
def shared_pods
9-
pod 'Alamofire', '4.8.2'
10-
pod 'Atributika', '4.8.2'
11-
pod 'SwiftyJSON', '4.1.0'
12-
pod 'SDWebImage', '4.4.2'
8+
pod 'Alamofire', '4.9.0'
9+
pod 'Atributika', '4.9.0'
10+
pod 'SwiftyJSON', '5.0.0'
11+
pod 'SDWebImage', '5.2.3'
1312
pod 'SVGKit', :git => 'https://github.com/SVGKit/SVGKit.git', :branch => '2.x'
1413
pod 'Fabric', '1.10.2'
1514
pod 'Crashlytics', '3.14.0'
16-
pod 'DeviceKit', '1.10.0'
17-
pod 'PromiseKit', '6.8.4'
18-
pod 'SwiftLint', '0.31.0'
15+
pod 'DeviceKit', '1.13.0'
16+
pod 'PromiseKit', '6.11.0'
17+
pod 'SwiftLint', '0.35.0'
1918
pod 'Reveal-SDK', :configurations => ['Debug']
2019
end
2120

2221
def all_pods
23-
2422
shared_pods
23+
2524
pod 'DownloadButton', '0.1.0'
2625
pod 'SVProgressHUD', '2.2.5'
26+
# TSMessages is no longer being maintained/updated, remove or migrate to RMessage/SwiftMessages
2727
pod 'TSMessages', :git => 'https://github.com/KrauseFx/TSMessages.git'
28-
pod 'YandexMobileMetrica/Dynamic', '3.2.0'
28+
pod 'YandexMobileMetrica/Dynamic', '3.8.2'
2929

3030
pod 'SnapKit', '4.2.0'
31-
32-
pod 'FirebaseCore', '5.1.0'
33-
pod 'FirebaseMessaging' , '3.1.0'
34-
pod 'FirebaseAnalytics' , '5.1.0'
35-
pod 'FirebaseRemoteConfig', '3.0.1'
3631

37-
pod 'Amplitude-iOS', '4.3.0'
32+
# Firebase
33+
pod 'Firebase/Core', '6.10.0'
34+
pod 'Firebase/Messaging' , '6.10.0'
35+
pod 'Firebase/Analytics' , '6.10.0'
36+
pod 'Firebase/RemoteConfig', '6.10.0'
37+
38+
pod 'Amplitude-iOS', '4.8.2'
3839

3940
pod 'BEMCheckBox', '1.4.1'
4041

41-
pod 'IQKeyboardManagerSwift', '6.2.1'
42+
pod 'IQKeyboardManagerSwift', '6.5.1'
4243

43-
pod 'Kanna', '4.0.1'
44+
pod 'Kanna', '4.0.3'
45+
# Remove after NotificationsService refactoring
4446
pod 'CRToast', '0.0.9'
4547
pod 'TUSafariActivity', '1.0.4'
4648

47-
pod 'VK-ios-sdk', '1.4.6'
48-
pod 'FBSDKCoreKit', '4.35.0'
49-
pod 'FBSDKLoginKit', '4.35.0'
49+
pod 'VK-ios-sdk', '1.5.1'
50+
pod 'FBSDKCoreKit', '5.8.0'
51+
pod 'FBSDKLoginKit', '5.8.0'
5052

51-
pod 'Presentr', '1.3.2'
53+
pod 'Presentr', '1.9'
5254

53-
pod 'Agrume', :git => 'https://github.com/JanGorman/Agrume.git'
55+
pod 'Agrume', '5.3.2'
5456
pod 'Highlightr', '2.1.0'
55-
pod 'RFKeyboardToolbar', '1.3'
5657
pod 'TTTAttributedLabel', '2.0.0'
57-
pod 'lottie-ios', '2.5.0'
58+
pod 'lottie-ios', '2.5.3'
5859
pod 'Koloda', '4.7'
59-
pod 'Charts', '3.2.2'
60+
pod 'Charts', '3.4.0'
6061
pod 'EasyTipView', '2.0.4'
6162
pod 'ActionSheetPicker-3.0', '2.3.0'
62-
pod 'NotificationBannerSwift', '2.0.1'
63-
pod 'Nuke', '7.3.2'
64-
pod 'STRegex', '2.0.0'
65-
pod 'Tabman', '2.4.1'
66-
pod 'Branch', '0.25.5'
63+
pod 'Nuke', '7.6.3'
64+
pod 'STRegex', '2.1.0'
65+
pod 'Tabman', '2.4.3'
66+
pod 'Branch', '0.25.11'
6767
end
6868

6969
def testing_pods
70-
pod 'Quick', '1.3.1'
71-
pod 'Nimble', '8.0.1'
70+
pod 'Quick', '2.2.0'
71+
pod 'Nimble', '8.0.4'
7272
pod 'Mockingjay', '2.0.1'
7373
end
7474

0 commit comments

Comments
 (0)