Skip to content

Commit 4883dff

Browse files
authored
Update quiz feedback wrong appearance (#533)
* Update wrong feedback titles * Update quiz feedback wrong icon
1 parent f2dba19 commit 4883dff

File tree

5 files changed

+15
-4
lines changed

5 files changed

+15
-4
lines changed
Binary file not shown.

Stepic/Sources/Modules/Quizzes/BaseQuiz/BaseQuizPresenter.swift

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,11 @@ final class BaseQuizPresenter: BaseQuizPresenterProtocol {
193193
if submissionsLeft == 0 {
194194
return NSLocalizedString("WrongFeedbackTitleLastTry", comment: "")
195195
}
196-
return NSLocalizedString("WrongFeedbackTitleNotLastTry", comment: "")
196+
return (1...3)
197+
// swiftlint:disable:next nslocalizedstring_key
198+
.map { NSLocalizedString("WrongFeedbackTitleNotLastTry\($0)", comment: "") }
199+
.randomElement()
200+
.require()
197201
case .evaluation:
198202
return NSLocalizedString("EvaluationFeedbackTitle", comment: "")
199203
}

Stepic/Sources/Modules/Quizzes/BaseQuiz/Views/QuizFeedbackView.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,14 @@ final class QuizFeedbackView: UIView {
185185
let view = UIImageView(
186186
image: UIImage(named: "quiz-feedback-correct")?.withRenderingMode(.alwaysTemplate)
187187
)
188+
view.contentMode = .scaleAspectFit
188189
view.tintColor = self.titleColor
189190
return view
190191
case .wrong:
191192
let view = UIImageView(
192193
image: UIImage(named: "quiz-feedback-wrong")?.withRenderingMode(.alwaysTemplate)
193194
)
195+
view.contentMode = .scaleAspectFit
194196
view.tintColor = self.titleColor
195197
return view
196198
case .evaluation:
@@ -202,6 +204,7 @@ final class QuizFeedbackView: UIView {
202204
let view = UIImageView(
203205
image: UIImage(named: "quiz-feedback-info")?.withRenderingMode(.alwaysTemplate)
204206
)
207+
view.contentMode = .scaleAspectFit
205208
view.tintColor = self.titleColor
206209
return view
207210
}

Stepic/en.lproj/Localizable.strings

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,9 @@ CorrectFeedbackTitle12 = "Yes!";
723723
CorrectFeedbackTitle13 = "Great!";
724724
CorrectFeedbackTitle14 = "Well done!";
725725
CorrectFeedbackTitleFreeAnswer = "Any text response will be graded as correct.";
726-
WrongFeedbackTitleNotLastTry = "Wrong. Let's try again.";
726+
WrongFeedbackTitleNotLastTry1 = "Wrong. Let's try again.";
727+
WrongFeedbackTitleNotLastTry2 = "No. Time for the next try.";
728+
WrongFeedbackTitleNotLastTry3 = "Try again, incorrect answer.";
727729
WrongFeedbackTitleLastTry = "Incorrect.";
728730
EvaluationFeedbackTitle = "Evaluation...";
729731
PeerReviewFeedbackTitle = "This is a task with peer review. Tap to open in web to get points.";

Stepic/ru.lproj/Localizable.strings

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -724,8 +724,10 @@ CorrectFeedbackTitle12 = "Так точно!";
724724
CorrectFeedbackTitle13 = "Отлично!";
725725
CorrectFeedbackTitle14 = "Всё получилось!";
726726
CorrectFeedbackTitleFreeAnswer = "Любой ответ будет оценен как правильный.";
727-
WrongFeedbackTitleNotLastTry = "Пока неправильно, попробуйте еще раз!";
728-
WrongFeedbackTitleLastTry = "Неверно!";
727+
WrongFeedbackTitleNotLastTry1 = "Пока неправильно, попробуйте ещё раз.";
728+
WrongFeedbackTitleNotLastTry2 = "Пока неверно, но вы можете попробовать ещё.";
729+
WrongFeedbackTitleNotLastTry3 = "Не получилось. Ещё немного и вы точно сможете.";
730+
WrongFeedbackTitleLastTry = "Неверно.";
729731
EvaluationFeedbackTitle = "Проверка...";
730732
PeerReviewFeedbackTitle = "Это задание с рецензией. Нажмите, чтобы закончить задание в веб-версии и получить баллы.";
731733
NextStepNavigationTitle = "Дальше";

0 commit comments

Comments
 (0)