Fix course has certificate (#1086)

* Use with_certificate instead of custom computed property

Author: ivan-magda

Stepic/Legacy/Model/Entities/Course/Course.swift

@@ -71,16 +71,10 @@ final class Course: NSManagedObject, ManagedObject, IDFetchable {
         self.purchases.contains(where: { $0.isActive })
     }
 
-    var anyCertificateTreshold: Int? {
+    var anyCertificateThreshold: Int? {
         self.certificateRegularThreshold ?? self.certificateDistinctionThreshold
     }
 
-    var hasCertificate: Bool {
-        let hasText = !self.certificate.isEmpty
-        let isIssued = self.isCertificatesAutoIssued && self.isCertificateIssued
-        return self.anyCertificateTreshold != nil && (hasText || isIssued)
-    }
-
     var defaultPromoCode: PromoCode? {
         if let defaultPromoCodeName = self.defaultPromoCodeName,
            let defaultPromoCodePrice = self.defaultPromoCodePrice {

Stepic/Sources/Modules/CourseInfoSubmodules/CourseInfoTabInfo/CourseInfoTabInfoPresenter.swift

@@ -39,7 +39,7 @@ final class CourseInfoTabInfoPresenter: CourseInfoTabInfoPresenterProtocol {
         let aboutText = course.courseDescription.isEmpty ? course.summary : course.courseDescription
 
         let certificateText = self.makeFormattedCertificateText(course: course)
-        let certificateDetailsText = course.hasCertificate
+        let certificateDetailsText = course.isWithCertificate
             ? self.makeFormattedCertificateDetailsText(
                 conditionPoints: course.certificateRegularThreshold,
                 distinctionPoints: course.certificateDistinctionThreshold
@@ -91,12 +91,12 @@ final class CourseInfoTabInfoPresenter: CourseInfoTabInfoPresenterProtocol {
     }
 
     private func makeFormattedCertificateText(course: Course) -> String {
-        let predefinedText = course.hasCertificate
+        let predefinedText = course.isWithCertificate
             ? NSLocalizedString("CertificateIsIssued", comment: "")
             : NSLocalizedString("CertificateIsNotIssued", comment: "")
         let certificateText = course.certificate.trimmingCharacters(in: .whitespaces)
 
-        return course.hasCertificate && !certificateText.isEmpty
+        return course.isWithCertificate && !certificateText.isEmpty
             ? certificateText
             : predefinedText
     }

Stepic/Sources/Modules/CourseList/CourseListPresenter.swift

@@ -130,7 +130,7 @@ final class CourseListPresenter: CourseListPresenterProtocol {
             ratingLabelText = FormatterHelper.averageRating(averageRating)
         }
 
-        let certificateLabelText = course.hasCertificate ? NSLocalizedString("Certificate", comment: "") : nil
+        let certificateLabelText = course.isWithCertificate ? NSLocalizedString("Certificate", comment: "") : nil
 
         var priceViewModel: CourseWidgetPriceViewModel?
         if isCoursePricesEnabled {

Stepic/Sources/Modules/LessonPanModals/LessonFinishedStepsPanModal/LessonFinishedStepsPanModalPresenter.swift

@@ -96,8 +96,8 @@ final class LessonFinishedStepsPanModalPresenter: LessonFinishedStepsPanModalPre
                 return didWriteReview ? .successWithoutCertWithReview : .successWithoutCertWithoutReview
             }
         } else {
-            let didReceiveCertificate = course.anyCertificateTreshold != nil
-                ? (progressScore >= Float(course.anyCertificateTreshold.require()))
+            let didReceiveCertificate = course.anyCertificateThreshold != nil
+                ? (progressScore >= Float(course.anyCertificateThreshold.require()))
                 : false
 
             if didReceiveCertificate {
@@ -261,7 +261,7 @@ final class LessonFinishedStepsPanModalPresenter: LessonFinishedStepsPanModalPre
              .successWithCertWithoutReview,
              .successWithCertWithReview:
             let progressScore = course.progress?.score ?? 0
-            let anyCertificateThreshold = Float(course.anyCertificateTreshold ?? 0)
+            let anyCertificateThreshold = Float(course.anyCertificateThreshold ?? 0)
 
             let needScore = anyCertificateThreshold - progressScore