Fix avatars #102
Merged
Fix avatars #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ostrenkiy
suggested changes
Aug 29, 2017
Stepic/AvatarImageView.swift
Outdated
| private func extractLetters(from svgString: String) -> String? { | ||
| let xmlWOClosingTags = svgString.replacingOccurrences(of: "</text></svg>", with: "") | ||
| let letters = xmlWOClosingTags.components(separatedBy: ">").last | ||
| return letters |
Contributor
There was a problem hiding this comment.
Возможно, тут стоит проверить длину letters, чтобы не получилось, что мы что-то другое распарсили
| import Alamofire | ||
| import SVGKit | ||
|
|
||
| class AvatarImageView: UIImageView { |
Contributor
There was a problem hiding this comment.
Здесь стоит еще делать setRoundedBounds() для UIImageView. Так мы в дальнейшем сможем изменять форму всех аватаров одновременно, не изменяя ее во всех местах, где AvatarImageView задействован
Contributor
Author
There was a problem hiding this comment.
Теперь делаем setRoundedBounds(width: 0) внутри вьюхи (из других мест это выпилено).
При этом, в TeacherCollectionViewCell есть вызов setRoundedBounds(width: 1, color: UIColor.white). Нам действительно нужна однопиксельная обводка у аватарок преподавателей на странице инфы о курсе? 🤔
Ostrenkiy
approved these changes
Aug 29, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1420
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Исправлено отображение аватаров
Описание:
SVGKit плохо рендерит текст в svg аватаре. Теперь пытаемся сами взять текст из полученного аватара, после чего генерируем новый средствами UIKit.