Tooltips #218
Merged
Tooltips #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvld
approved these changes
Jan 25, 2018
| pod 'Atributika', '~> 4.0' | ||
| pod 'DeviceKit', '~> 1.0' | ||
| pod 'lottie-ios' | ||
| pod 'EasyTipView', :git => 'https://github.com/igorkislyuk/EasyTipView.git' |
Contributor
There was a problem hiding this comment.
А почему какой-то форк юзаем? Swift 4?
| private let didShowOnHomeContinueLearningKey = "didShowOnHomeContinueLearningKey" | ||
| private let didShowOnStreaksSwitchInProfileKey = "didShowOnStreaksSwitchInProfileKey" | ||
|
|
||
| var didShowOnLessonDownloads: Bool { |
Contributor
There was a problem hiding this comment.
И у нас на каждый тултип геттер и сеттер? Может быть это можно было написать оптимальнее – возможно, это не так удобно, но не надо зато копипастить будет в будущем.
Например:
enum TooltipType {
var key: String {
switch self { ... }
}
case lessonDownloads, streaksSwitchInProfile
}
func didShowTooltip(with type: TooltipType) -> Bool { ... }
func shouldShowTooltip(with type: TooltipType) -> Bool { ... }
func updateTooltip(with type: TooltipType, show: Bool) { ... }
Contributor
Author
There was a problem hiding this comment.
норм, берем на заметку, но пока так мерджим
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1735
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Добавили тултипы для подсказок пользователю
Описание:
Используется фреймворк EasyTipView.
Тултипы перекрыты протоколом
Tooltip, создаются вTooltipFactory. Дальше тултипы появляются во всем местах, указанных в задаче #APPS-1605.В
UIColorExtensionsдобавленthirdColor = UIColor(hex: 0x54a2ff)