-
Notifications
You must be signed in to change notification settings - Fork 34
Integrate with the Amplitude analytics #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| struct ConfigureAnalyticsCommand: Command { | ||
| func execute() { | ||
| Amplitude.instance().initializeApiKey(Tokens.shared.amplitudeToken) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Наверное лучше убрать в ConfigureThirdPartiesCommand.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Если честно, не очень понимаю, для чего нужен еще один слой абстракции в виде Command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это имело бы смысл, если бы нам надо было как-то персистентно сохранять команду, в противном случае все делается без этого или внутри сервиса
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kvld поправь, если я не прав
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ostrenkiy знаешь, как это бывает: начитаешься всяких статей и тянешь потом, тянешь за собой )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ну короче как выпилишь можно вмердживать, все события приходят
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ostrenkiy выпилил, теперь всё по православному 😄
|
Я, видимо, не застал ничего уже. Поэтому ок всё |
Задача: #APPS-2035
Описание:
Добавили отправку событий в Амплитуду.
Событие об отправке решения отправляется в QuizPresenter